diff mbox

[PATCHv2,fixincludes] Ignore .DS_Store junk files when running make check

Message ID CAMfHzOteS3ZZ0vGXSgTVs3if_GOSPxGvoYRcSfQ4fD9qdEtM5g@mail.gmail.com
State New
Headers show

Commit Message

Eric Gallager July 28, 2015, 2:36 a.m. UTC 
On 7/27/15, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Eric Gallager <egall@gwmail.gwu.edu> writes:
>
>> Okay, I tried embedding "! -name CVS/ ! -name .svn/" into the find
>
> -name does an exact match, so you don't need the slash.
>
> Andreas.
>

Okay, attached a new version of the patch; make check for fixincludes
still passes with it. Could someone commit it for me? I don't have
commit access. It's still pretty trivial, so I shouldn't need a
copyright assignment for it, should I?

Eric.
fixincludes/check.tpl | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Bruce Korb July 28, 2015, 1:38 p.m. UTC | #1 
Definitely much better.  I won't apply it until the weekend, so
someone else will likely beat me to it.  Thank you.

On Mon, Jul 27, 2015 at 7:36 PM, Eric Gallager <egall@gwmail.gwu.edu> wrote:
> On 7/27/15, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Eric Gallager <egall@gwmail.gwu.edu> writes:
>>
>>> Okay, I tried embedding "! -name CVS/ ! -name .svn/" into the find
Mike Stump July 28, 2015, 6:11 p.m. UTC | #2 
On Jul 28, 2015, at 6:38 AM, Bruce Korb <bkorb@gnu.org> wrote:
> Definitely much better.  I won't apply it until the weekend, so
> someone else will likely beat me to it.

Looks good to me as well, I checked it in.

Committed revision 226317.
Mike Stump July 28, 2015, 6:16 p.m. UTC | #3 
On Jul 27, 2015, at 7:36 PM, Eric Gallager <egall@gwmail.gwu.edu> wrote:
> On 7/27/15, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Eric Gallager <egall@gwmail.gwu.edu> writes:
>> 
>>> Okay, I tried embedding "! -name CVS/ ! -name .svn/" into the find
>> 
>> -name does an exact match, so you don't need the slash.

> Okay, attached a new version of the patch; make check for fixincludes
> still passes with it.

If someone can test the gcc-5 branch with it and if it fixes it, I’ll approve it for the 5 branch as well.
diff mbox

Patch

diff --git a/fixincludes/check.tpl b/fixincludes/check.tpl
index 0d1f444..ffd2b66 100644
--- a/fixincludes/check.tpl
+++ b/fixincludes/check.tpl
@@ -141,9 +141,8 @@  echo $exitok`
 
 cd $TESTBASE
 
-find * -type f -print | \
-fgrep -v 'CVS/' | \
-fgrep -v '.svn/' > ${TESTDIR}/LIST
+find * -type f ! -name .DS_Store ! -name CVS ! -name .svn -print \
+> ${TESTDIR}/LIST
 
 exitok=`
 exec < ${TESTDIR}/LIST