diff mbox

[U-Boot,7/7] net: lpc32xx: eth buffers base config

Message ID 1438018660-19858-8-git-send-email-slemieux.tyco@gmail.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Sylvain Lemieux July 27, 2015, 5:37 p.m. UTC 
From: Sylvain Lemieux <slemieux@tycoint.com>

Add support to specify the Ethernet buffer base address;
if none are supply by the board, the default value is use (from existing code).

Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
---
 drivers/net/lpc32xx_eth.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Joe Hershberger Aug. 11, 2015, 5:39 p.m. UTC | #1 
Hi Sylvain,

On Mon, Jul 27, 2015 at 12:37 PM,  <slemieux.tyco@gmail.com> wrote:
> From: Sylvain Lemieux <slemieux@tycoint.com>
>
> Add support to specify the Ethernet buffer base address;
> if none are supply by the board, the default value is use (from existing code).
>
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini Aug. 13, 2015, 1:20 p.m. UTC | #2 
On Mon, Jul 27, 2015 at 01:37:40PM -0400, slemieux.tyco@gmail.com wrote:

> From: Sylvain Lemieux <slemieux@tycoint.com>
> 
> Add support to specify the Ethernet buffer base address;
> if none are supply by the board, the default value is use (from existing code).
> 
> Signed-off-by: Sylvain Lemieux <slemieux@tycoint.com>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/net/lpc32xx_eth.c b/drivers/net/lpc32xx_eth.c
index f3ab0f4..e76e9bc 100644
--- a/drivers/net/lpc32xx_eth.c
+++ b/drivers/net/lpc32xx_eth.c
@@ -353,15 +353,17 @@  int lpc32xx_eth_phy_write(struct mii_dev *bus, int phy_addr, int dev_addr,
 #endif
 
 /*
+ * Provide default Ethernet buffers base address if target did not.
  * Locate buffers in SRAM at 0x00001000 to avoid cache issues and
  * maximize throughput.
  */
-
-#define LPC32XX_ETH_BUFS 0x00001000
+#if !defined(CONFIG_LPC32XX_ETH_BUFS_BASE)
+#define CONFIG_LPC32XX_ETH_BUFS_BASE 0x00001000
+#endif
 
 static struct lpc32xx_eth_device lpc32xx_eth = {
 	.regs = (struct lpc32xx_eth_registers *)LPC32XX_ETH_BASE,
-	.bufs = (struct lpc32xx_eth_buffers *)LPC32XX_ETH_BUFS,
+	.bufs = (struct lpc32xx_eth_buffers *)CONFIG_LPC32XX_ETH_BUFS_BASE,
 #if defined(CONFIG_RMII)
 	.phy_rmii = true,
 #endif