diff mbox

[U-Boot,2/3] ARM: tegra: Use standard cache enable for 64-bit

Message ID 1438019126-3498-2-git-send-email-swarren@wwwdotorg.org
State Accepted
Delegated to: Tom Warren
Headers show

Commit Message

Stephen Warren July 27, 2015, 5:45 p.m. UTC 
From: Thierry Reding <treding@nvidia.com>

On 64-bit SoCs the I-cache isn't enabled in early code, so the default
cache enable functions for 64-bit ARM can be used.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Tom Warren <twarren@nvidia.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/mach-tegra/board.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass July 28, 2015, 3:33 p.m. UTC | #1 
Hi,

On 27 July 2015 at 11:45, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> On 64-bit SoCs the I-cache isn't enabled in early code, so the default
> cache enable functions for 64-bit ARM can be used.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  arch/arm/mach-tegra/board.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Does this mean that U-Boot starts slowly?

Regards,
Simon
Stephen Warren July 28, 2015, 3:42 p.m. UTC | #2 
On 07/28/2015 09:33 AM, Simon Glass wrote:
> Hi,
>
> On 27 July 2015 at 11:45, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> On 64-bit SoCs the I-cache isn't enabled in early code, so the default
>> cache enable functions for 64-bit ARM can be used.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>> Signed-off-by: Tom Warren <twarren@nvidia.com>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>>   arch/arm/mach-tegra/board.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Does this mean that U-Boot starts slowly?

I haven't noticed it being slow:-)
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/board.c b/arch/arm/mach-tegra/board.c
index 222de6a7352d..58e996ecff70 100644
--- a/arch/arm/mach-tegra/board.c
+++ b/arch/arm/mach-tegra/board.c
@@ -182,7 +182,7 @@  void board_init_uart_f(void)
 	setup_uarts(uart_ids);
 }
 
-#ifndef CONFIG_SYS_DCACHE_OFF
+#if !defined(CONFIG_SYS_DCACHE_OFF) && !defined(CONFIG_ARM64)
 void enable_caches(void)
 {
 	/* Enable D-cache. I-cache is already enabled in start.S */