diff mbox

[v1,1/1] package/rtl8821au: remove debugging patch

Message ID 1438014835-11707-1-git-send-email-christian@paral.in
State Accepted
Headers show

Commit Message

Christian Stewart July 27, 2015, 4:33 p.m. UTC 
This patch updates rtl8821au to include an upstream commit which
disables debug output without a runtime insmod parameter debug=level.
This makes the old buildroot patch to remove hardcoded debug defines
unnecessary: as such, it has been removed.

Signed-off-by: Christian Stewart <christian@paral.in>
---
 package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
 package/rtl8821au/rtl8821au.mk                     |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)
 delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch

Comments

Christian Stewart July 27, 2015, 4:55 p.m. UTC | #1 
All,

I've just tested this version on an Odroid XU3 running ARM with an Edimax
USB wifi card. No debugging output without the insmod argument.

Tested-by: Christian Stewart <christian@paral.in>

Best,
Christian

On Mon, Jul 27, 2015 at 9:34 AM Christian Stewart <christian@paral.in>
wrote:

> This patch updates rtl8821au to include an upstream commit which
> disables debug output without a runtime insmod parameter debug=level.
> This makes the old buildroot patch to remove hardcoded debug defines
> unnecessary: as such, it has been removed.
>
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
>  package/rtl8821au/0001-disable-default-debug.patch | 24
> ----------------------
>  package/rtl8821au/rtl8821au.mk                     |  2 +-
>  2 files changed, 1 insertion(+), 25 deletions(-)
>  delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
>
> diff --git a/package/rtl8821au/0001-disable-default-debug.patch
> b/package/rtl8821au/0001-disable-default-debug.patch
> deleted file mode 100644
> index de6fc62..0000000
> --- a/package/rtl8821au/0001-disable-default-debug.patch
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Comment out the hardcoded debug defines. If extra debug is needed, we can
> add it
> -as a define in the make flags.
> -
> -Signed-off-by: Christian Stewart <christian@paral.in>
> -
> -diff --git a/include/autoconf.h b/include/autoconf.h
> ---- a/include/autoconf.h
> -+++ b/include/autoconf.h
> -@@ -130,12 +130,12 @@
> - /*
> -  * Debug Related Config
> -  */
> --#define DBG   1
> -+//#define DBG 1
> -
> --#define CONFIG_DEBUG /* DBG_871X, etc... */
> -+//#define CONFIG_DEBUG /* DBG_871X, etc... */
> - //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_,
> _func_exit_ */
> -
> --#define CONFIG_PROC_DEBUG
> -+//#define CONFIG_PROC_DEBUG
> -
> -
> - //#define DBG_TX
> diff --git a/package/rtl8821au/rtl8821au.mk b/package/rtl8821au/
> rtl8821au.mk
> index d218e3c..eddb18e 100644
> --- a/package/rtl8821au/rtl8821au.mk
> +++ b/package/rtl8821au/rtl8821au.mk
> @@ -4,7 +4,7 @@
>  #
>
>  ################################################################################
>
> -RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
> +RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
>  RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
>  RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
>  RTL8821AU_LICENSE_FILES = COPYING
> --
> 2.1.4
>
>
Yann E. MORIN July 27, 2015, 5:25 p.m. UTC | #2 
Christian, All,

On 2015-07-27 09:33 -0700, Christian Stewart spake thusly:
> This patch updates rtl8821au to include an upstream commit which
> disables debug output without a runtime insmod parameter debug=level.

s/without/with/

> This makes the old buildroot patch to remove hardcoded debug defines
> unnecessary: as such, it has been removed.
> 
> Signed-off-by: Christian Stewart <christian@paral.in>

Otherwise:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
>  package/rtl8821au/rtl8821au.mk                     |  2 +-
>  2 files changed, 1 insertion(+), 25 deletions(-)
>  delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
> 
> diff --git a/package/rtl8821au/0001-disable-default-debug.patch b/package/rtl8821au/0001-disable-default-debug.patch
> deleted file mode 100644
> index de6fc62..0000000
> --- a/package/rtl8821au/0001-disable-default-debug.patch
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -Comment out the hardcoded debug defines. If extra debug is needed, we can add it
> -as a define in the make flags.
> -
> -Signed-off-by: Christian Stewart <christian@paral.in>
> -
> -diff --git a/include/autoconf.h b/include/autoconf.h
> ---- a/include/autoconf.h
> -+++ b/include/autoconf.h
> -@@ -130,12 +130,12 @@
> - /*
> -  * Debug Related Config
> -  */
> --#define DBG	1
> -+//#define DBG	1
> - 
> --#define CONFIG_DEBUG /* DBG_871X, etc... */
> -+//#define CONFIG_DEBUG /* DBG_871X, etc... */
> - //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_, _func_exit_ */
> - 
> --#define CONFIG_PROC_DEBUG
> -+//#define CONFIG_PROC_DEBUG
> - 
> - 
> - //#define DBG_TX
> diff --git a/package/rtl8821au/rtl8821au.mk b/package/rtl8821au/rtl8821au.mk
> index d218e3c..eddb18e 100644
> --- a/package/rtl8821au/rtl8821au.mk
> +++ b/package/rtl8821au/rtl8821au.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
> +RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
>  RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
>  RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
>  RTL8821AU_LICENSE_FILES = COPYING
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Yann E. MORIN July 27, 2015, 5:32 p.m. UTC | #3 
Christian, All,

On 2015-07-27 19:25 +0200, Yann E. MORIN spake thusly:
> On 2015-07-27 09:33 -0700, Christian Stewart spake thusly:
> > This patch updates rtl8821au to include an upstream commit which
> > disables debug output without a runtime insmod parameter debug=level.
> 
> s/without/with/

As discussed on IRC, this was nt clear enough, so here's an alternate
phrasing:

    ... an upstream commit which disables debug output, unless a runtime
    insmod parameter debug=level is passed when loading the module.

Regards,
Yann E. MORIN.

> > This makes the old buildroot patch to remove hardcoded debug defines
> > unnecessary: as such, it has been removed.
> > 
> > Signed-off-by: Christian Stewart <christian@paral.in>
> 
> Otherwise:
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Regards,
> Yann E. MORIN.
> 
> > ---
> >  package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
> >  package/rtl8821au/rtl8821au.mk                     |  2 +-
> >  2 files changed, 1 insertion(+), 25 deletions(-)
> >  delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
> > 
> > diff --git a/package/rtl8821au/0001-disable-default-debug.patch b/package/rtl8821au/0001-disable-default-debug.patch
> > deleted file mode 100644
> > index de6fc62..0000000
> > --- a/package/rtl8821au/0001-disable-default-debug.patch
> > +++ /dev/null
> > @@ -1,24 +0,0 @@
> > -Comment out the hardcoded debug defines. If extra debug is needed, we can add it
> > -as a define in the make flags.
> > -
> > -Signed-off-by: Christian Stewart <christian@paral.in>
> > -
> > -diff --git a/include/autoconf.h b/include/autoconf.h
> > ---- a/include/autoconf.h
> > -+++ b/include/autoconf.h
> > -@@ -130,12 +130,12 @@
> > - /*
> > -  * Debug Related Config
> > -  */
> > --#define DBG	1
> > -+//#define DBG	1
> > - 
> > --#define CONFIG_DEBUG /* DBG_871X, etc... */
> > -+//#define CONFIG_DEBUG /* DBG_871X, etc... */
> > - //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_, _func_exit_ */
> > - 
> > --#define CONFIG_PROC_DEBUG
> > -+//#define CONFIG_PROC_DEBUG
> > - 
> > - 
> > - //#define DBG_TX
> > diff --git a/package/rtl8821au/rtl8821au.mk b/package/rtl8821au/rtl8821au.mk
> > index d218e3c..eddb18e 100644
> > --- a/package/rtl8821au/rtl8821au.mk
> > +++ b/package/rtl8821au/rtl8821au.mk
> > @@ -4,7 +4,7 @@
> >  #
> >  ################################################################################
> >  
> > -RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
> > +RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
> >  RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
> >  RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
> >  RTL8821AU_LICENSE_FILES = COPYING
> > -- 
> > 2.1.4
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni July 27, 2015, 9:05 p.m. UTC | #4 
Dear Christian Stewart,

On Mon, 27 Jul 2015 09:33:55 -0700, Christian Stewart wrote:
> This patch updates rtl8821au to include an upstream commit which
> disables debug output without a runtime insmod parameter debug=level.
> This makes the old buildroot patch to remove hardcoded debug defines
> unnecessary: as such, it has been removed.
> 
> Signed-off-by: Christian Stewart <christian@paral.in>
> ---
>  package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
>  package/rtl8821au/rtl8821au.mk                     |  2 +-
>  2 files changed, 1 insertion(+), 25 deletions(-)
>  delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch

I've applied after tweaking the commit log as suggested by Yann, and
also changed the commit title to:

	package/rtl8821au: bump version and remove debugging patch

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/rtl8821au/0001-disable-default-debug.patch b/package/rtl8821au/0001-disable-default-debug.patch
deleted file mode 100644
index de6fc62..0000000
--- a/package/rtl8821au/0001-disable-default-debug.patch
+++ /dev/null
@@ -1,24 +0,0 @@ 
-Comment out the hardcoded debug defines. If extra debug is needed, we can add it
-as a define in the make flags.
-
-Signed-off-by: Christian Stewart <christian@paral.in>
-
-diff --git a/include/autoconf.h b/include/autoconf.h
---- a/include/autoconf.h
-+++ b/include/autoconf.h
-@@ -130,12 +130,12 @@
- /*
-  * Debug Related Config
-  */
--#define DBG	1
-+//#define DBG	1
- 
--#define CONFIG_DEBUG /* DBG_871X, etc... */
-+//#define CONFIG_DEBUG /* DBG_871X, etc... */
- //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_, _func_exit_ */
- 
--#define CONFIG_PROC_DEBUG
-+//#define CONFIG_PROC_DEBUG
- 
- 
- //#define DBG_TX
diff --git a/package/rtl8821au/rtl8821au.mk b/package/rtl8821au/rtl8821au.mk
index d218e3c..eddb18e 100644
--- a/package/rtl8821au/rtl8821au.mk
+++ b/package/rtl8821au/rtl8821au.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
+RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
 RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
 RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
 RTL8821AU_LICENSE_FILES = COPYING