| Message ID | 1437985615-30791-1-git-send-email-b38611@freescale.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Jul 27, 2015 at 04:26:55PM +0800, Fugang Duan wrote: > For most of imx platforms, there have no DMA support for I2C bus. > So, by default, there is only cpu mode. > > The current driver to check whether there have DMA channel config in > dts file to judge whether it support DMA mode or not, if doesn't config > it print out "can't use DMA" for each bus during probe. > > kernel boot up log: > i2c i2c-0: IMX I2C adapter registered > i2c i2c-0: can't use DMA > i2c i2c-1: IMX I2C adapter registered > i2c i2c-1: can't use DMA > i2c i2c-2: IMX I2C adapter registered > i2c i2c-2: can't use DMA > i2c i2c-3: IMX I2C adapter registered > i2c i2c-3: can't use DMA Let's just drop this message. There is a success message when DMA is used which is good enough.
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 785aa67..28fba91 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -339,7 +339,7 @@ fail_tx: dma_release_channel(dma->chan_tx); fail_al: devm_kfree(dev, dma); - dev_info(dev, "can't use DMA\n"); + dev_dbg(dev, "can't use DMA\n"); } static void i2c_imx_dma_callback(void *arg)
For most of imx platforms, there have no DMA support for I2C bus. So, by default, there is only cpu mode. The current driver to check whether there have DMA channel config in dts file to judge whether it support DMA mode or not, if doesn't config it print out "can't use DMA" for each bus during probe. kernel boot up log: i2c i2c-0: IMX I2C adapter registered i2c i2c-0: can't use DMA i2c i2c-1: IMX I2C adapter registered i2c i2c-1: can't use DMA i2c i2c-2: IMX I2C adapter registered i2c i2c-2: can't use DMA i2c i2c-3: IMX I2C adapter registered i2c i2c-3: can't use DMA It is very ugly and confused. So change the dev_info() to deb_dbg() to avoid print dummy and redundant log. Signed-off-by: Fugang Duan <B38611@freescale.com> --- drivers/i2c/busses/i2c-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)