diff mbox

[v2,1/1] package/exfat-utils: fix compilation error with musl

Message ID 1437951045-14508-1-git-send-email-brendanheading@gmail.com
State Superseded, archived
Headers show

Commit Message

Brendan Heading July 26, 2015, 10:50 p.m. UTC 
exfat-utils build would not build on Linux unless __GLIBC__ was defined.
Patch added to use more relaxed __linux__ instead.

See http://autobuild.buildroot.net/results/c60/c60d0f9a93c90d41c3c86c78b0a0

Signed-off-by: Brendan Heading <brendanheading@gmail.com>

---
Changes v1 -> v2 :
   - removed unnecessary dependency change
   - improvements (much simpler patch) as suggested by Thomas P

Signed-off-by: Brendan Heading <brendanheading@gmail.com>
---
 .../0001-fix-compiling-with-non-glibc-libcs.patch  | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/exfat-utils/0001-fix-compiling-with-non-glibc-libcs.patch

Comments

Thomas Petazzoni July 27, 2015, 8:51 p.m. UTC | #1 
Dear Brendan Heading,

On Sun, 26 Jul 2015 23:50:45 +0100, Brendan Heading wrote:
> exfat-utils build would not build on Linux unless __GLIBC__ was defined.
> Patch added to use more relaxed __linux__ instead.
> 
> See http://autobuild.buildroot.net/results/c60/c60d0f9a93c90d41c3c86c78b0a0
> 
> Signed-off-by: Brendan Heading <brendanheading@gmail.com>
> 
> ---
> Changes v1 -> v2 :
>    - removed unnecessary dependency change
>    - improvements (much simpler patch) as suggested by Thomas P

Applied, thanks. Can you please submit the patch upstream?

Thomas
Brendan Heading July 27, 2015, 8:59 p.m. UTC | #2 
>
> Applied, thanks. Can you please submit the patch upstream?
>

Already done, and accepted by the upstream maintainer. I'll keep an eye out
for the next upstream release.

https://groups.google.com/forum/#!topic/exfat/8g3yumqrf1A

regards

Brendan
Thomas Petazzoni July 27, 2015, 9:13 p.m. UTC | #3 
Brendan,

On Mon, 27 Jul 2015 21:59:48 +0100, Brendan Heading wrote:
> >
> > Applied, thanks. Can you please submit the patch upstream?
> >
> 
> Already done, and accepted by the upstream maintainer. I'll keep an eye out
> for the next upstream release.
> 
> https://groups.google.com/forum/#!topic/exfat/8g3yumqrf1A

Great, thanks!

I've updated the patch to indicate its upstream status:

  http://git.buildroot.net/buildroot/commit/?id=efc54fe91ebd849618a15363602b84e53e15037d

Thanks,

Thomas
diff mbox

Patch

diff --git a/package/exfat-utils/0001-fix-compiling-with-non-glibc-libcs.patch b/package/exfat-utils/0001-fix-compiling-with-non-glibc-libcs.patch
new file mode 100644
index 0000000..6244b16
--- /dev/null
+++ b/package/exfat-utils/0001-fix-compiling-with-non-glibc-libcs.patch
@@ -0,0 +1,23 @@ 
+[PATCH] fix compilation when libc does not define __GLIBC__
+
+libexfat would only compile on Linux with __GLIBC__ defined. Changed
+to use __linux__ which likely better fits the original intent.
+
+Signed-off-by: Brendan Heading <brendanheading@gmail.com>
+---
+ platform.h |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: libexfat/libexfat/platform.h
+===================================================================
+--- libexfat/libexfat/platform.h	(revision 422)
++++ libexfat/libexfat/platform.h	(working copy)
+@@ -24,7 +24,7 @@
+ #ifndef PLATFORM_H_INCLUDED
+ #define PLATFORM_H_INCLUDED
+ 
+-#if defined(__GLIBC__)
++#if defined(__linux__)
+ 
+ #include <endian.h>
+ #include <byteswap.h>