diff mbox

ext4: memory leak on error in ext4_symlink()

Message ID 20150724110533.GA14424@mwanda
State Not Applicable, archived
Headers show

Commit Message

Dan Carpenter July 24, 2015, 11:05 a.m. UTC 
We should release "sd" before returning.

Fixes: 0fa12ad1b285 ('ext4: Handle error from dquot_initialize()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Jan Kara July 27, 2015, 12:32 p.m. UTC | #1 
On Fri 24-07-15 14:05:33, Dan Carpenter wrote:
> We should release "sd" before returning.
> 
> Fixes: 0fa12ad1b285 ('ext4: Handle error from dquot_initialize()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks! I've added the fix to my tree.

								Honza
 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index d3ff837..9f61e76 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -3084,7 +3084,7 @@ static int ext4_symlink(struct inode *dir,
>  
>  	err = dquot_initialize(dir);
>  	if (err)
> -		return err;
> +		goto err_free_sd;
>  
>  	if ((disk_link.len > EXT4_N_BLOCKS * 4)) {
>  		/*
>
diff mbox

Patch

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index d3ff837..9f61e76 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -3084,7 +3084,7 @@  static int ext4_symlink(struct inode *dir,
 
 	err = dquot_initialize(dir);
 	if (err)
-		return err;
+		goto err_free_sd;
 
 	if ((disk_link.len > EXT4_N_BLOCKS * 4)) {
 		/*