| Message ID | 1437720998-1208-1-git-send-email-guaneryu@gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Jul 24, 2015 at 02:56:38PM +0800, Eryu Guan wrote: > Commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize") > introduced a bug that c/mtime is not updated on truncate up. > > Fix the issue by setting c/mtime explicitly in the truncate up case. > > Note that ftruncate(2) is not affected, so you won't see this bug using > truncate(1) and xfs_io(1). > > Signed-off-by: Zirong Lang <zorro.lang@gmail.com> > Signed-off-by: Eryu Guan <guaneryu@gmail.com> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index cecf9aa..2442eb0 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4725,6 +4725,14 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) error = ext4_orphan_add(handle, inode); orphan = 1; } + /* + * Update c/mtime on truncate up, ext4_truncate() will + * update c/mtime in shrink case below + */ + if (!shrink) { + inode->i_mtime = ext4_current_time(inode); + inode->i_ctime = inode->i_mtime; + } down_write(&EXT4_I(inode)->i_data_sem); EXT4_I(inode)->i_disksize = attr->ia_size; rc = ext4_mark_inode_dirty(handle, inode);
Commit 3da40c7b0898 ("ext4: only call ext4_truncate when size <= isize") introduced a bug that c/mtime is not updated on truncate up. Fix the issue by setting c/mtime explicitly in the truncate up case. Note that ftruncate(2) is not affected, so you won't see this bug using truncate(1) and xfs_io(1). Signed-off-by: Zirong Lang <zorro.lang@gmail.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com> --- fs/ext4/inode.c | 8 ++++++++ 1 file changed, 8 insertions(+)