[COMMITTED] Add SIGWINCH to generic <bits/signum.h>.
diff mbox

Message ID 20150723234606.D04D92C3B92@topped-with-meat.com
State New
Headers show

Commit Message

Roland McGrath July 23, 2015, 11:46 p.m. UTC
The only configuration affected by this is NaCl.  I've declared it a "bug
fix" because all real-world POSIX systems have SIGWINCH, so the "generic"
GNU API should include it.


Thanks,
Roland


	* bits/signum.h: Update comments to mention 1003.1-2013 too.
	(SIGWINCH): New macro.

Comments

Carlos O'Donell July 24, 2015, 12:11 a.m. UTC | #1
On 07/23/2015 07:46 PM, Roland McGrath wrote:
> The only configuration affected by this is NaCl.  I've declared it a "bug
> fix" because all real-world POSIX systems have SIGWINCH, so the "generic"
> GNU API should include it.

If it's a publicly visible bug it should have a bug filed for it.

c.
Roland McGrath July 24, 2015, 12:20 a.m. UTC | #2
> On 07/23/2015 07:46 PM, Roland McGrath wrote:
> > The only configuration affected by this is NaCl.  I've declared it a "bug
> > fix" because all real-world POSIX systems have SIGWINCH, so the "generic"
> > GNU API should include it.
> 
> If it's a publicly visible bug it should have a bug filed for it.

Well, it was only visible in the arm-nacl configuration, and there has not
been a release that had that configuration.  So so such bugs were actually
user-visible for certain definitions of user.
Carlos O'Donell July 24, 2015, 12:38 a.m. UTC | #3
On 07/23/2015 08:20 PM, Roland McGrath wrote:
>> On 07/23/2015 07:46 PM, Roland McGrath wrote:
>>> The only configuration affected by this is NaCl.  I've declared it a "bug
>>> fix" because all real-world POSIX systems have SIGWINCH, so the "generic"
>>> GNU API should include it.
>>
>> If it's a publicly visible bug it should have a bug filed for it.
> 
> Well, it was only visible in the arm-nacl configuration, and there has not
> been a release that had that configuration.  So so such bugs were actually
> user-visible for certain definitions of user.

OK.

Should NaCl get mention in the README?

c.
Roland McGrath July 24, 2015, 1:06 a.m. UTC | #4
> Should NaCl get mention in the README?

I was going to add it to the list when I added the NEWS item.  But then I
noticed that the list of tuples is titled ".. for using Linux kernels" and
README and failed to notice the whole separate paragraph about Hurd.  As is
the case for Hurd, people interested in the NaCl configuration will be
starting from NaCl information and get their pointers to building glibc
that way.  I don't think anybody getting glibc and not knowing about NaCl
support already will be looking at README to find it.
Carlos O'Donell July 24, 2015, 2:42 a.m. UTC | #5
On 07/23/2015 09:06 PM, Roland McGrath wrote:
>> Should NaCl get mention in the README?
> 
> I was going to add it to the list when I added the NEWS item.  But then I
> noticed that the list of tuples is titled ".. for using Linux kernels" and
> README and failed to notice the whole separate paragraph about Hurd.  As is
> the case for Hurd, people interested in the NaCl configuration will be
> starting from NaCl information and get their pointers to building glibc
> that way.  I don't think anybody getting glibc and not knowing about NaCl
> support already will be looking at README to find it.

That seems like a poor excuse for not updating README?

Add some text about the port and point to the online docs?

c.

Patch
diff mbox

diff --git a/bits/signum.h b/bits/signum.h
index a07a9b4..e6deefd 100644
--- a/bits/signum.h
+++ b/bits/signum.h
@@ -28,9 +28,13 @@ 
 # define SIG_HOLD ((__sighandler_t)  2)	/* Add signal to hold mask.  */
 #endif
 
-/* We define here all the signal names listed in POSIX (1003.1-2008).
+/* We define here all the signal names listed in POSIX (1003.1-2008);
+   as of 1003.1-2013, no additional signals have been added by POSIX.
+   We also define here signal names that historically exist in every
+   real-world POSIX variant (e.g. SIGWINCH).
+
    Signals in the 1-15 range are defined with their historical numbers.
-   For other signals specified by POSIX, we use the BSD numbers.  */
+   For other signals, we use the BSD numbers.  */
 
 /* ISO C99 signals.  */
 #define	SIGINT		2	/* Interactive attention signal.  */
@@ -50,7 +54,7 @@ 
 #define	SIGPIPE		13	/* Broken pipe.  */
 #define	SIGALRM		14	/* Alarm clock.  */
 
-/* New(er) POSIX signals (1003.1-2008).  */
+/* New(er) POSIX signals (1003.1-2008, 1003.1-2013).  */
 #define	SIGURG		16 /* High bandwidth data is available at a socket.  */
 #define	SIGSTOP		17	/* Stopped (signal).  */
 #define	SIGTSTP		18	/* Stopped.  */
@@ -67,10 +71,14 @@ 
 #define	SIGUSR1		30	/* User-defined signal 1.  */
 #define	SIGUSR2		31	/* User-defined signal 2.  */
 
+/* Nonstandard signals found in all modern POSIX systems
+   (including both BSD and Linux).  */
+#define	SIGWINCH	28	/* Window size change (4.3 BSD, Sun).  */
+
 #define	_NSIG		32
 
 /* Archaic names for compatibility. */
-#define	SIGIOT		SIGABRT	/* IOT instruction, abort() on a PDP11 */
+#define	SIGIOT		SIGABRT	/* IOT instruction, abort() on a PDP-11.  */
 #define	SIGCLD		SIGCHLD	/* Old System V name */
 
 #endif	/* <signal.h> included.  */