Patchwork [Lucid] SRU: SAUCE: rt2x00: Remove USB ID of Linksys WUSB54GC v3

login
register
mail settings
Submitter Keng-Yu Lin
Date April 12, 2010, 3:31 a.m.
Message ID <1271043110-31143-1-git-send-email-keng-yu.lin@canonical.com>
Download mbox | patch
Permalink /patch/49938/
State Rejected
Delegated to: Stefan Bader
Headers show

Comments

Keng-Yu Lin - April 12, 2010, 3:31 a.m.
SRU Justification:

Impact: It is reported that the wireless dongle Linksys WUSB54GC v3 does not
work at all with rt2x00 driver. Scanning finds no network.

Fix: To remove the USB ID of WUSB54GC v3 from rt2x00. This enforces
rt2870/rt3070 in the staging tree to be used.

Test: Several users report in the Launchpad that the driver in the staging
tree works though also some users said it fails with some wireless encryption
combinations. I suspect it is due to protocol compatibility issue, e.g.
using TKIP with WPA2, etc. But unencrypted wireless always works. So this
patch at least gives users wireless functionality to some degree.

--
From 1fb67b38b9a73572e9ac9f53a6393c1f6dca1202 Mon Sep 17 00:00:00 2001
From: Keng-Yu Lin <keng-yu.lin@canonical.com>
Date: Fri, 19 Mar 2010 09:51:31 +0800
Subject: [PATCH] UBUNTU: SAUCE: rt2x00: Remove USB ID of Linksys WUSB54GC v3

OriginalAuthor: btmorex <https://bugs.launchpad.net/~avery-shadypixel>
OriginalLocation: http://launchpadlibrarian.net/34085839/rt3070-fix.patch
BugLink: http://bugs.launchpad.net/bugs/446889

The removal of the USB ID from rt2x00 enforces rt2870/rt3070 in staging tree
to be used. rt2x00 is reported not working at all.

Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
---
 drivers/net/wireless/rt2x00/rt2800usb.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Stefan Bader - April 12, 2010, 2:23 p.m.
Looks like another case of patch that should go upstream. When doing so, I would
also propose it as stable material.

-Stefan

Keng-Yu Lin wrote:
> SRU Justification:
> 
> Impact: It is reported that the wireless dongle Linksys WUSB54GC v3 does not
> work at all with rt2x00 driver. Scanning finds no network.
> 
> Fix: To remove the USB ID of WUSB54GC v3 from rt2x00. This enforces
> rt2870/rt3070 in the staging tree to be used.
> 
> Test: Several users report in the Launchpad that the driver in the staging
> tree works though also some users said it fails with some wireless encryption
> combinations. I suspect it is due to protocol compatibility issue, e.g.
> using TKIP with WPA2, etc. But unencrypted wireless always works. So this
> patch at least gives users wireless functionality to some degree.
> 
> --
> From 1fb67b38b9a73572e9ac9f53a6393c1f6dca1202 Mon Sep 17 00:00:00 2001
> From: Keng-Yu Lin <keng-yu.lin@canonical.com>
> Date: Fri, 19 Mar 2010 09:51:31 +0800
> Subject: [PATCH] UBUNTU: SAUCE: rt2x00: Remove USB ID of Linksys WUSB54GC v3
> 
> OriginalAuthor: btmorex <https://bugs.launchpad.net/~avery-shadypixel>
> OriginalLocation: http://launchpadlibrarian.net/34085839/rt3070-fix.patch
> BugLink: http://bugs.launchpad.net/bugs/446889
> 
> The removal of the USB ID from rt2x00 enforces rt2870/rt3070 in staging tree
> to be used. rt2x00 is reported not working at all.
> 
> Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
> ---
>  drivers/net/wireless/rt2x00/rt2800usb.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
> index 9fe770f..fae1c36 100644
> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -2963,7 +2963,6 @@ static struct usb_device_id rt2800usb_device_table[] = {
>  	/* Linksys */
>  	{ USB_DEVICE(0x1737, 0x0070), USB_DEVICE_DATA(&rt2800usb_ops) },
>  	{ USB_DEVICE(0x1737, 0x0071), USB_DEVICE_DATA(&rt2800usb_ops) },
> -	{ USB_DEVICE(0x1737, 0x0077), USB_DEVICE_DATA(&rt2800usb_ops) },
>  	/* Logitec */
>  	{ USB_DEVICE(0x0789, 0x0162), USB_DEVICE_DATA(&rt2800usb_ops) },
>  	{ USB_DEVICE(0x0789, 0x0163), USB_DEVICE_DATA(&rt2800usb_ops) },
Stefan Bader - April 30, 2010, 9:53 a.m.
Stefan Bader wrote:
> Looks like another case of patch that should go upstream. When doing so, I would
> also propose it as stable material.

Keng-Yu, have you sent that upstream and made sure it will added to stable?

-Stefan

> -Stefan
> 
> Keng-Yu Lin wrote:
>> SRU Justification:
>>
>> Impact: It is reported that the wireless dongle Linksys WUSB54GC v3 does not
>> work at all with rt2x00 driver. Scanning finds no network.
>>
>> Fix: To remove the USB ID of WUSB54GC v3 from rt2x00. This enforces
>> rt2870/rt3070 in the staging tree to be used.
>>
>> Test: Several users report in the Launchpad that the driver in the staging
>> tree works though also some users said it fails with some wireless encryption
>> combinations. I suspect it is due to protocol compatibility issue, e.g.
>> using TKIP with WPA2, etc. But unencrypted wireless always works. So this
>> patch at least gives users wireless functionality to some degree.
>>
>> --
>> From 1fb67b38b9a73572e9ac9f53a6393c1f6dca1202 Mon Sep 17 00:00:00 2001
>> From: Keng-Yu Lin <keng-yu.lin@canonical.com>
>> Date: Fri, 19 Mar 2010 09:51:31 +0800
>> Subject: [PATCH] UBUNTU: SAUCE: rt2x00: Remove USB ID of Linksys WUSB54GC v3
>>
>> OriginalAuthor: btmorex <https://bugs.launchpad.net/~avery-shadypixel>
>> OriginalLocation: http://launchpadlibrarian.net/34085839/rt3070-fix.patch
>> BugLink: http://bugs.launchpad.net/bugs/446889
>>
>> The removal of the USB ID from rt2x00 enforces rt2870/rt3070 in staging tree
>> to be used. rt2x00 is reported not working at all.
>>
>> Signed-off-by: Keng-Yu Lin <keng-yu.lin@canonical.com>
>> ---
>>  drivers/net/wireless/rt2x00/rt2800usb.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
>> index 9fe770f..fae1c36 100644
>> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
>> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
>> @@ -2963,7 +2963,6 @@ static struct usb_device_id rt2800usb_device_table[] = {
>>  	/* Linksys */
>>  	{ USB_DEVICE(0x1737, 0x0070), USB_DEVICE_DATA(&rt2800usb_ops) },
>>  	{ USB_DEVICE(0x1737, 0x0071), USB_DEVICE_DATA(&rt2800usb_ops) },
>> -	{ USB_DEVICE(0x1737, 0x0077), USB_DEVICE_DATA(&rt2800usb_ops) },
>>  	/* Logitec */
>>  	{ USB_DEVICE(0x0789, 0x0162), USB_DEVICE_DATA(&rt2800usb_ops) },
>>  	{ USB_DEVICE(0x0789, 0x0163), USB_DEVICE_DATA(&rt2800usb_ops) },
> 
>
Brad Figg - Sept. 13, 2010, 5:42 p.m.
On 04/30/2010 02:53 AM, Stefan Bader wrote:
> Stefan Bader wrote:
>> Looks like another case of patch that should go upstream. When doing so, I would
>> also propose it as stable material.
>
> Keng-Yu, have you sent that upstream and made sure it will added to stable?
>
> -Stefan
>
>> -Stefan
>>
>> Keng-Yu Lin wrote:
>>> SRU Justification:
>>>
>>> Impact: It is reported that the wireless dongle Linksys WUSB54GC v3 does not
>>> work at all with rt2x00 driver. Scanning finds no network.
>>>
>>> Fix: To remove the USB ID of WUSB54GC v3 from rt2x00. This enforces
>>> rt2870/rt3070 in the staging tree to be used.
>>>
>>> Test: Several users report in the Launchpad that the driver in the staging
>>> tree works though also some users said it fails with some wireless encryption
>>> combinations. I suspect it is due to protocol compatibility issue, e.g.
>>> using TKIP with WPA2, etc. But unencrypted wireless always works. So this
>>> patch at least gives users wireless functionality to some degree.
>>>
>>> --
>>>  From 1fb67b38b9a73572e9ac9f53a6393c1f6dca1202 Mon Sep 17 00:00:00 2001
>>> From: Keng-Yu Lin<keng-yu.lin@canonical.com>
>>> Date: Fri, 19 Mar 2010 09:51:31 +0800
>>> Subject: [PATCH] UBUNTU: SAUCE: rt2x00: Remove USB ID of Linksys WUSB54GC v3
>>>
>>> OriginalAuthor: btmorex<https://bugs.launchpad.net/~avery-shadypixel>
>>> OriginalLocation: http://launchpadlibrarian.net/34085839/rt3070-fix.patch
>>> BugLink: http://bugs.launchpad.net/bugs/446889
>>>
>>> The removal of the USB ID from rt2x00 enforces rt2870/rt3070 in staging tree
>>> to be used. rt2x00 is reported not working at all.
>>>
>>> Signed-off-by: Keng-Yu Lin<keng-yu.lin@canonical.com>
>>> ---
>>>   drivers/net/wireless/rt2x00/rt2800usb.c |    1 -
>>>   1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
>>> index 9fe770f..fae1c36 100644
>>> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
>>> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
>>> @@ -2963,7 +2963,6 @@ static struct usb_device_id rt2800usb_device_table[] = {
>>>   	/* Linksys */
>>>   	{ USB_DEVICE(0x1737, 0x0070), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>   	{ USB_DEVICE(0x1737, 0x0071), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> -	{ USB_DEVICE(0x1737, 0x0077), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>   	/* Logitec */
>>>   	{ USB_DEVICE(0x0789, 0x0162), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>   	{ USB_DEVICE(0x0789, 0x0163), USB_DEVICE_DATA(&rt2800usb_ops) },
>>
>>
>
>

Keng-Yu,

Any update on this patch? Has it been submitted upstream and is it still necessary?

Brad
Keng-Yu Lin - Sept. 14, 2010, 5:51 a.m.
On Tue, Sep 14, 2010 at 1:42 AM, Brad Figg <brad.figg@canonical.com> wrote:
> On 04/30/2010 02:53 AM, Stefan Bader wrote:
>>
>> Stefan Bader wrote:
>>>
>>> Looks like another case of patch that should go upstream. When doing so,
>>> I would
>>> also propose it as stable material.
>>
>> Keng-Yu, have you sent that upstream and made sure it will added to
>> stable?
>>
>> -Stefan
>>
>>> -Stefan
>>>
>>> Keng-Yu Lin wrote:
>>>>
>>>> SRU Justification:
>>>>
>>>> Impact: It is reported that the wireless dongle Linksys WUSB54GC v3 does
>>>> not
>>>> work at all with rt2x00 driver. Scanning finds no network.
>>>>
>>>> Fix: To remove the USB ID of WUSB54GC v3 from rt2x00. This enforces
>>>> rt2870/rt3070 in the staging tree to be used.
>>>>
>>>> Test: Several users report in the Launchpad that the driver in the
>>>> staging
>>>> tree works though also some users said it fails with some wireless
>>>> encryption
>>>> combinations. I suspect it is due to protocol compatibility issue, e.g.
>>>> using TKIP with WPA2, etc. But unencrypted wireless always works. So
>>>> this
>>>> patch at least gives users wireless functionality to some degree.
>>>>
>>>> --
>>>>  From 1fb67b38b9a73572e9ac9f53a6393c1f6dca1202 Mon Sep 17 00:00:00 2001
>>>> From: Keng-Yu Lin<keng-yu.lin@canonical.com>
>>>> Date: Fri, 19 Mar 2010 09:51:31 +0800
>>>> Subject: [PATCH] UBUNTU: SAUCE: rt2x00: Remove USB ID of Linksys
>>>> WUSB54GC v3
>>>>
>>>> OriginalAuthor: btmorex<https://bugs.launchpad.net/~avery-shadypixel>
>>>> OriginalLocation:
>>>> http://launchpadlibrarian.net/34085839/rt3070-fix.patch
>>>> BugLink: http://bugs.launchpad.net/bugs/446889
>>>>
>>>> The removal of the USB ID from rt2x00 enforces rt2870/rt3070 in staging
>>>> tree
>>>> to be used. rt2x00 is reported not working at all.
>>>>
>>>> Signed-off-by: Keng-Yu Lin<keng-yu.lin@canonical.com>
>>>> ---
>>>>  drivers/net/wireless/rt2x00/rt2800usb.c |    1 -
>>>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> b/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> index 9fe770f..fae1c36 100644
>>>> --- a/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> +++ b/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> @@ -2963,7 +2963,6 @@ static struct usb_device_id
>>>> rt2800usb_device_table[] = {
>>>>        /* Linksys */
>>>>        { USB_DEVICE(0x1737, 0x0070), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>>        { USB_DEVICE(0x1737, 0x0071), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> -       { USB_DEVICE(0x1737, 0x0077), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>>        /* Logitec */
>>>>        { USB_DEVICE(0x0789, 0x0162), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>>        { USB_DEVICE(0x0789, 0x0163), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>
>>>
>>
>>
>
> Keng-Yu,
>
> Any update on this patch? Has it been submitted upstream and is it still
> necessary?
>
> Brad
> --
> Brad Figg brad.figg@canonical.com http://www.canonical.com
>

From the feedback in LP, rt2870sta in staging tree does not solve the
WPA/WPA2 issue perfectly either. I'd like to leave this patch out.

Since the USB VID/PID of this device was already added in
staging/rt2870sta, users can just blacklist rt2800usb or rt2870sta for
switching the driver to use at will.

  Thanks,
-kengyu

Patch

diff --git a/drivers/net/wireless/rt2x00/rt2800usb.c b/drivers/net/wireless/rt2x00/rt2800usb.c
index 9fe770f..fae1c36 100644
--- a/drivers/net/wireless/rt2x00/rt2800usb.c
+++ b/drivers/net/wireless/rt2x00/rt2800usb.c
@@ -2963,7 +2963,6 @@  static struct usb_device_id rt2800usb_device_table[] = {
 	/* Linksys */
 	{ USB_DEVICE(0x1737, 0x0070), USB_DEVICE_DATA(&rt2800usb_ops) },
 	{ USB_DEVICE(0x1737, 0x0071), USB_DEVICE_DATA(&rt2800usb_ops) },
-	{ USB_DEVICE(0x1737, 0x0077), USB_DEVICE_DATA(&rt2800usb_ops) },
 	/* Logitec */
 	{ USB_DEVICE(0x0789, 0x0162), USB_DEVICE_DATA(&rt2800usb_ops) },
 	{ USB_DEVICE(0x0789, 0x0163), USB_DEVICE_DATA(&rt2800usb_ops) },