diff mbox

[U-Boot] ARM: tegra: Build warning fixes for 64-bit

Message ID 1437602285-13522-1-git-send-email-swarren@wwwdotorg.org
State Accepted
Delegated to: Tom Warren
Headers show

Commit Message

Stephen Warren July 22, 2015, 9:58 p.m. UTC
From: Thierry Reding <treding@nvidia.com>

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Tom Warren <twarren@nvidia.com>
[swarren, stripped out changes not strictly related to warnings]
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
Tom, if you look at https://github.com/swarren/u-boot/tree/t210-testing
you'll see commit "ARM: tegra: parts of 64-bit port". Those changes were
originally included in Thierry's version of this patch, but aren't
strictly related to build warnings. I separated them out to keep warning
fixes and 64-bit support separate. I think you should squash "ARM: tegra:
parts of 64-bit port" into your T210 support series. Does that seem
reasonable?

 arch/arm/mach-tegra/ap.c            | 4 ++--
 arch/arm/mach-tegra/pinmux-common.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Simon Glass July 23, 2015, 8:18 p.m. UTC | #1
On 22 July 2015 at 15:58, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> [swarren, stripped out changes not strictly related to warnings]
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Tom, if you look at https://github.com/swarren/u-boot/tree/t210-testing
> you'll see commit "ARM: tegra: parts of 64-bit port". Those changes were
> originally included in Thierry's version of this patch, but aren't
> strictly related to build warnings. I separated them out to keep warning
> fixes and 64-bit support separate. I think you should squash "ARM: tegra:
> parts of 64-bit port" into your T210 support series. Does that seem
> reasonable?
>
>  arch/arm/mach-tegra/ap.c            | 4 ++--
>  arch/arm/mach-tegra/pinmux-common.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/arch/arm/mach-tegra/ap.c b/arch/arm/mach-tegra/ap.c
index 0b94e8aaf9c3..7b89c0107196 100644
--- a/arch/arm/mach-tegra/ap.c
+++ b/arch/arm/mach-tegra/ap.c
@@ -131,8 +131,8 @@  static u32 get_odmdata(void)
 	 * on BCTs for currently supported SoCs, which are locked down.
 	 * If this changes in new chips, we can revisit this algorithm.
 	 */
-
-	u32 bct_start, odmdata;
+	unsigned long bct_start;
+	u32 odmdata;
 
 	bct_start = readl(NV_PA_BASE_SRAM + NVBOOTINFOTABLE_BCTPTR);
 	odmdata = readl(bct_start + BCT_ODMDATA_OFFSET);
diff --git a/arch/arm/mach-tegra/pinmux-common.c b/arch/arm/mach-tegra/pinmux-common.c
index b4a1432afcb1..5862c4ac3dc6 100644
--- a/arch/arm/mach-tegra/pinmux-common.c
+++ b/arch/arm/mach-tegra/pinmux-common.c
@@ -78,7 +78,7 @@ 
 	(((hsm) >= PMUX_HSM_DISABLE) && ((hsm) <= PMUX_HSM_ENABLE))
 #endif
 
-#define _R(offset)	(u32 *)(NV_PA_APB_MISC_BASE + (offset))
+#define _R(offset)	(u32 *)((unsigned long)NV_PA_APB_MISC_BASE + (offset))
 
 #if defined(CONFIG_TEGRA20)