| Message ID | 1437601197-6481-8-git-send-email-wdavis@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed, Jul 22, 2015 at 04:39:52PM -0500, Will Davis wrote: > This function takes a struct pci_bus * and returns the associated struct > pci_host_bridge * upstream. Nits: for the PCI parts, please run "git log --oneline" and make yours match the style of the previous history. Same for the changelog text itself, which can be an imperative sentence, e.g., something like: Return the struct pci_host_bridge corresponding to the given pci_bus. Text like "This function ..." or "This patch ..." is superfluous because we already know the changelog applies to *this* patch. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c index 5f4a2e0..6c2c82a 100644 --- a/drivers/pci/host-bridge.c +++ b/drivers/pci/host-bridge.c @@ -8,25 +8,10 @@ #include "pci.h" -static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) -{ - while (bus->parent) - bus = bus->parent; - - return bus; -} - -struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus) -{ - struct pci_bus *root_bus = find_pci_root_bus(bus); - - return to_pci_host_bridge(root_bus->bridge); -} - struct device *pci_get_host_bridge_device(struct pci_dev *dev) { - struct pci_bus *root_bus = find_pci_root_bus(dev->bus); - struct device *bridge = root_bus->bridge; + struct pci_host_bridge *host_bridge = pci_find_host_bridge(dev->bus); + struct device *bridge = &host_bridge->dev; kobject_get(&bridge->kobj); return bridge; diff --git a/include/linux/pci.h b/include/linux/pci.h index 8a0321a..d58063e 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -512,6 +512,13 @@ static inline struct pci_dev *pci_upstream_bridge(struct pci_dev *dev) return dev->bus->self; } +static inline struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus) +{ + while (bus->parent) + bus = bus->parent; + return to_pci_host_bridge(bus->bridge); +} + struct device *pci_get_host_bridge_device(struct pci_dev *dev); void pci_put_host_bridge_device(struct device *dev);
This function takes a struct pci_bus * and returns the associated struct pci_host_bridge * upstream. Signed-off-by: Will Davis <wdavis@nvidia.com> --- drivers/pci/host-bridge.c | 19 ++----------------- include/linux/pci.h | 7 +++++++ 2 files changed, 9 insertions(+), 17 deletions(-)