| Message ID | fb80b9139bec21ac8bd4ddcec0abeb9c1ad39ad5@localhost.localdomain |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2010-04-09 at 15:45 -0700, Kevin Cernekee wrote: > With gcc 4.4.3 -O2 on MIPS32: > > drivers/mtd/chips/cfi_util.c: In function 'cfi_qry_present': > include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function > include/linux/mtd/map.h:375: note: 'r' was declared here > include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function > include/linux/mtd/map.h:375: note: 'r' was declared here > > Signed-off-by: Kevin Cernekee <cernekee@gmail.com> I suspect 'else BUG()' would be a better fix.
diff --git a/include/linux/mtd/map.h b/include/linux/mtd/map.h index b981b87..74f0277 100644 --- a/include/linux/mtd/map.h +++ b/include/linux/mtd/map.h @@ -372,7 +372,7 @@ static inline map_word map_word_ff(struct map_info *map) static inline map_word inline_map_read(struct map_info *map, unsigned long ofs) { - map_word r; + map_word r = { { 0 } }; if (map_bankwidth_is_1(map)) r.x[0] = __raw_readb(map->virt + ofs);
With gcc 4.4.3 -O2 on MIPS32: drivers/mtd/chips/cfi_util.c: In function 'cfi_qry_present': include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function include/linux/mtd/map.h:375: note: 'r' was declared here include/linux/mtd/map.h:390: warning: 'r' may be used uninitialized in this function include/linux/mtd/map.h:375: note: 'r' was declared here Signed-off-by: Kevin Cernekee <cernekee@gmail.com> --- include/linux/mtd/map.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)