diff mbox

[U-Boot,32/48] x86: Add a link script entry for U-Boot as a payload

Message ID 1437580180-6405-33-git-send-email-sjg@chromium.org
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass July 22, 2015, 3:49 p.m. UTC
Allow U-Boot to be packaged into the image as a binary payload.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 arch/x86/cpu/efi/elf_ia32_efi.lds | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bin Meng July 23, 2015, 12:15 p.m. UTC | #1
Hi Simon,

On Wed, Jul 22, 2015 at 11:49 PM, Simon Glass <sjg@chromium.org> wrote:
> Allow U-Boot to be packaged into the image as a binary payload.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

But please check comments below.

> ---
>
>  arch/x86/cpu/efi/elf_ia32_efi.lds | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/cpu/efi/elf_ia32_efi.lds b/arch/x86/cpu/efi/elf_ia32_efi.lds
> index fca008b..87ddb4d 100644
> --- a/arch/x86/cpu/efi/elf_ia32_efi.lds
> +++ b/arch/x86/cpu/efi/elf_ia32_efi.lds
> @@ -57,6 +57,9 @@ SECTIONS
>                 KEEP(*(SORT(.u_boot_list*)));
>                 . = ALIGN(8);
>                 KEEP(*(.dtb*));
> +               /* Keep U-Boot payload */
> +               . = ALIGN(8);
> +               KEEP(*(.u_boot_bin.*));

I don't see section .u_boot_bin defined so far. Assume it is
introduced in later patches, so please consider the patch order.

>         }
>         .dynamic  : { *(.dynamic) }
>         . = ALIGN(4096);
> --

Regards,
Bin
diff mbox

Patch

diff --git a/arch/x86/cpu/efi/elf_ia32_efi.lds b/arch/x86/cpu/efi/elf_ia32_efi.lds
index fca008b..87ddb4d 100644
--- a/arch/x86/cpu/efi/elf_ia32_efi.lds
+++ b/arch/x86/cpu/efi/elf_ia32_efi.lds
@@ -57,6 +57,9 @@  SECTIONS
 		KEEP(*(SORT(.u_boot_list*)));
 		. = ALIGN(8);
 		KEEP(*(.dtb*));
+		/* Keep U-Boot payload */
+		. = ALIGN(8);
+		KEEP(*(.u_boot_bin.*));
 	}
 	.dynamic  : { *(.dynamic) }
 	. = ALIGN(4096);