Patchwork PCI quirk: Disable MSI on VIA K8T890 systems

login
register
mail settings
Submitter Chase Douglas
Date April 9, 2010, 3:26 p.m.
Message ID <1270826812-3924-1-git-send-email-chase.douglas@canonical.com>
Download mbox | patch
Permalink /patch/49848/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Chase Douglas - April 9, 2010, 3:26 p.m.
From: Matthew Wilcox <matthew@wil.cx>

Bugzilla 15287 indicates that there's a problem with Message Signalled
Interrupts on VIA K8T890 systems.  Add a quirk to disable MSI on these
systems.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Tested-by: Jan Kreuzer <kontrollator@gmx.de>
Tested-by: lh <jarryson@gmail.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

cherry-picked with munging from 134b345081534235dbf228b1005c14590e0570ba

BugLink: http://bugs.launchpad.net/bugs/544741

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/pci/quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Andy Whitcroft - April 9, 2010, 3:42 p.m.
On Fri, Apr 09, 2010 at 11:26:52AM -0400, Chase Douglas wrote:
> From: Matthew Wilcox <matthew@wil.cx>
> 
> Bugzilla 15287 indicates that there's a problem with Message Signalled
> Interrupts on VIA K8T890 systems.  Add a quirk to disable MSI on these
> systems.
> 
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
> Tested-by: Jan Kreuzer <kontrollator@gmx.de>
> Tested-by: lh <jarryson@gmail.com>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> cherry-picked with munging from 134b345081534235dbf228b1005c14590e0570ba
> 
> BugLink: http://bugs.launchpad.net/bugs/544741
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
>  drivers/pci/quirks.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 745ed53..462c55b 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2093,6 +2093,7 @@ static void __devinit quirk_disable_msi(struct pci_dev *dev)
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x5a3f, quirk_disable_msi);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, 0xa238, quirk_disable_msi);
>  
>  /* Go through the list of Hypertransport capabilities and
>   * return 1 if a HT MSI capability is found and enabled */

Looks safe.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Leann Ogasawara - April 9, 2010, 4:23 p.m.
On Fri, 2010-04-09 at 11:26 -0400, Chase Douglas wrote:
> From: Matthew Wilcox <matthew@wil.cx>
> 
> Bugzilla 15287 indicates that there's a problem with Message Signalled
> Interrupts on VIA K8T890 systems.  Add a quirk to disable MSI on these
> systems.
> 
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
> Tested-by: Jan Kreuzer <kontrollator@gmx.de>
> Tested-by: lh <jarryson@gmail.com>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> cherry-picked with munging from 134b345081534235dbf228b1005c14590e0570ba
> 
> BugLink: http://bugs.launchpad.net/bugs/544741
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>

Looks good.

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com)

> ---
>  drivers/pci/quirks.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 745ed53..462c55b 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2093,6 +2093,7 @@ static void __devinit quirk_disable_msi(struct pci_dev *dev)
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x5a3f, quirk_disable_msi);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, 0xa238, quirk_disable_msi);
>  
>  /* Go through the list of Hypertransport capabilities and
>   * return 1 if a HT MSI capability is found and enabled */
> -- 
> 1.7.0
> 
>
Andy Whitcroft - April 9, 2010, 4:27 p.m.
Applied to Lucid.

-apw

Patch

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 745ed53..462c55b 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2093,6 +2093,7 @@  static void __devinit quirk_disable_msi(struct pci_dev *dev)
 }
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x5a3f, quirk_disable_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_VIA, 0xa238, quirk_disable_msi);
 
 /* Go through the list of Hypertransport capabilities and
  * return 1 if a HT MSI capability is found and enabled */