diff mbox

[4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure

Message ID 1437418902-23324-1-git-send-email-tim.gardner@canonical.com (mailing list archive)
State Superseded
Headers show

Commit Message

Tim Gardner July 20, 2015, 7:01 p.m. UTC 
From: Tim Gardner <tim.gardner@canonical.com>

drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
 module_init(anslcd_init);
 ^
drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]

gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)

Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---

This is a compile regression from v4.2-rc2

 drivers/macintosh/ans-lcd.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Michael Ellerman July 23, 2015, 10:18 a.m. UTC | #1 
On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote:
> From: Tim Gardner <tim.gardner@canonical.com>
> 
> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
>  module_init(anslcd_init);
>  ^
> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
> 
> gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)

Thanks Tim but Luis beat you to it:

  http://patchwork.ozlabs.org/patch/497138/


I'll send the fix to Linus in the next day or two.

cheers
Tim Gardner July 23, 2015, 12:12 p.m. UTC | #2 
On 07/23/2015 04:18 AM, Michael Ellerman wrote:
> On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote:
>> From: Tim Gardner <tim.gardner@canonical.com>
>>
>> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class
>>   module_init(anslcd_init);
>>   ^
>> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
>>
>> gcc version 4.9.3 (Ubuntu 4.9.3-1ubuntu1)
>
> Thanks Tim but Luis beat you to it:
>
>    http://patchwork.ozlabs.org/patch/497138/
>
>
> I'll send the fix to Linus in the next day or two.
>
> cheers
>

No problem. It looks like a better fix then mine anyway.

rtg
diff mbox

Patch

diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c
index 1a57e88..36a0047 100644
--- a/drivers/macintosh/ans-lcd.c
+++ b/drivers/macintosh/ans-lcd.c
@@ -5,6 +5,7 @@ 
 #include <linux/types.h>
 #include <linux/errno.h>
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/miscdevice.h>
 #include <linux/fcntl.h>
 #include <linux/init.h>