diff mbox

[01/11] package/ulogd: remove autoreconf

Message ID 1437414479-16714-1-git-send-email-romain.naour@openwide.fr
State Accepted
Headers show

Commit Message

Romain Naour July 20, 2015, 5:47 p.m. UTC
Autoreconf is not needed anymore since ulogd 2.0.4
where logd-01-pthread-conditional.patch was removed.

commit: 010745a955b6cf4c979588fafdb7506460038e0f

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/ulogd/ulogd.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Petazzoni July 20, 2015, 8:56 p.m. UTC | #1
Dear Romain Naour,

On Mon, 20 Jul 2015 19:47:49 +0200, Romain Naour wrote:
> Autoreconf is not needed anymore since ulogd 2.0.4
> where logd-01-pthread-conditional.patch was removed.
> 
> commit: 010745a955b6cf4c979588fafdb7506460038e0f
> 
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
>  package/ulogd/ulogd.mk | 1 -
>  1 file changed, 1 deletion(-)

All 11 patches applied, thanks. I have not tested them, I trust you :)
The autobuilders will tell me if I was right or not! :-)

Thanks!

Thomas
Romain Naour July 22, 2015, 10:29 a.m. UTC | #2
Hi Thomas,

Le 20/07/2015 22:56, Thomas Petazzoni a écrit :
> Dear Romain Naour,
> 
> On Mon, 20 Jul 2015 19:47:49 +0200, Romain Naour wrote:
>> Autoreconf is not needed anymore since ulogd 2.0.4
>> where logd-01-pthread-conditional.patch was removed.
>>
>> commit: 010745a955b6cf4c979588fafdb7506460038e0f
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>  package/ulogd/ulogd.mk | 1 -
>>  1 file changed, 1 deletion(-)
> 
> All 11 patches applied, thanks. I have not tested them, I trust you :)
> The autobuilders will tell me if I was right or not! :-)

I haven't see any build failure due to this series :)
So, I guess you was right but maybe there are too many build failure in
autobuilders to see something ;-)

Seriously, I've tested each packages by selecting each of them in the config and
build the entire config to see if all build fine.

Thanks,
Romain

> 
> Thanks!
> 
> Thomas
>
Thomas Petazzoni July 22, 2015, 11:31 a.m. UTC | #3
Romain,

On Wed, 22 Jul 2015 12:29:24 +0200, Romain Naour wrote:

> > All 11 patches applied, thanks. I have not tested them, I trust you :)
> > The autobuilders will tell me if I was right or not! :-)
> 
> I haven't see any build failure due to this series :)
> So, I guess you was right but maybe there are too many build failure in
> autobuilders to see something ;-)
> 
> Seriously, I've tested each packages by selecting each of them in the config and
> build the entire config to see if all build fine.

Yes, so far I haven't identified any of the build failure to be caused
by this series, so it looks good. Of course as you say, there are quite
a lot of build failures currently, so it's hard to say if it really
didn't cause any regression.

But no worries, I'm sure it's going to be OK :)

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/ulogd/ulogd.mk b/package/ulogd/ulogd.mk
index 7ff5b73..7730198 100644
--- a/package/ulogd/ulogd.mk
+++ b/package/ulogd/ulogd.mk
@@ -8,7 +8,6 @@  ULOGD_VERSION = 2.0.5
 ULOGD_SOURCE = ulogd-$(ULOGD_VERSION).tar.bz2
 ULOGD_SITE = http://www.netfilter.org/projects/ulogd/files
 ULOGD_CONF_OPTS = --with-dbi=no --with-pgsql=no
-ULOGD_AUTORECONF = YES
 ULOGD_DEPENDENCIES = host-pkgconf \
 	libmnl libnetfilter_acct libnetfilter_conntrack libnetfilter_log \
 	libnfnetlink