diff mbox

ARM: tegra: Fix nyan-big panel binding

Message ID 1437336913-12886-1-git-send-email-steev@gentoo.org
State Rejected, archived
Headers show

Commit Message

Steev Klimaszewski July 19, 2015, 8:15 p.m. UTC
The nyan-big Chromebook uses a 1920x1080 panel, not a 1366x768 panel so correct
the binding.

Signed-off-by: Steev Klimaszewski <steev@gentoo.org>
---
 arch/arm/boot/dts/tegra124-nyan-big.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dylan Reid July 19, 2015, 10:43 p.m. UTC | #1
On Sun, Jul 19, 2015 at 2:15 PM, Steev Klimaszewski <threeway@gmail.com> wrote:
> The nyan-big Chromebook uses a 1920x1080 panel, not a 1366x768 panel so correct
> the binding.

This isn't incorrect, although it is not complete.  Nyan-big (Acer
CB5-311) has _both_ a 1920x1080 and 1366x768 variant available.  They
are referred to as the "Full HD" and "HD" models respectively.

>
> Signed-off-by: Steev Klimaszewski <steev@gentoo.org>
> ---
>  arch/arm/boot/dts/tegra124-nyan-big.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
> index 2d21253..30d4495 100644
> --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> @@ -9,7 +9,7 @@
>         compatible = "google,nyan-big", "nvidia,tegra124";
>
>         panel: panel {
> -               compatible = "auo,b133xtn01";
> +               compatible = "auo,b133htn01";
>
>                 backlight = <&backlight>;
>                 ddc-i2c-bus = <&dpaux>;
> --
> 2.4.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steev Klimaszewski July 19, 2015, 10:54 p.m. UTC | #2
On Sun, 2015-07-19 at 16:43 -0600, Dylan Reid wrote:
> On Sun, Jul 19, 2015 at 2:15 PM, Steev Klimaszewski <
> threeway@gmail.com> wrote:
> > The nyan-big Chromebook uses a 1920x1080 panel, not a 1366x768 
> > panel so correct
> > the binding.
> 
> This isn't incorrect, although it is not complete.  Nyan-big (Acer
> CB5-311) has _both_ a 1920x1080 and 1366x768 variant available.  They
> are referred to as the "Full HD" and "HD" models respectively.
> 

I wasn't aware they had the CB5-311 as a 1366x768 variant.  I guess we
need to split nyan-big up in mainline like ChromeOS does?  Should we do
the same thing that ChromeOS does and have each variant available?  I
noticed mine is actually a rev3_7 according to booting with a chromeos
kernel.  And for whatever reason, if I include both big and blaze in a
fit image using mainline, it always seems to pick the blaze dtb on my
big, so I'm guessing the compatible string is different as well.


> > 
> > Signed-off-by: Steev Klimaszewski <steev@gentoo.org>
> > ---
> >  arch/arm/boot/dts/tegra124-nyan-big.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts 
> > b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > index 2d21253..30d4495 100644
> > --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> > +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> > @@ -9,7 +9,7 @@
> >         compatible = "google,nyan-big", "nvidia,tegra124";
> > 
> >         panel: panel {
> > -               compatible = "auo,b133xtn01";
> > +               compatible = "auo,b133htn01";
> > 
> >                 backlight = <&backlight>;
> >                 ddc-i2c-bus = <&dpaux>;
> > --
> > 2.4.6
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux
> > -tegra" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Steev Klimaszewski July 20, 2015, 3:26 a.m. UTC | #3
On Sun, 2015-07-19 at 16:43 -0600, Dylan Reid wrote:
> On Sun, Jul 19, 2015 at 2:15 PM, Steev Klimaszewski <
> threeway@gmail.com> wrote:
> > The nyan-big Chromebook uses a 1920x1080 panel, not a 1366x768 
> > panel so correct
> > the binding.
> 
> This isn't incorrect, although it is not complete.  Nyan-big (Acer
> CB5-311) has _both_ a 1920x1080 and 1366x768 variant available.  They
> are referred to as the "Full HD" and "HD" models respectively.


Actually, as it turns out, that was a wrong turn. 

The real issue is that 1d002fa720738bcd0bddb9178e9ea0773288e1dd
(drm/dp: Use large transactions for I2C over AUX) breaks reading of
EDID data on the nyan_big "Full HD" - I'm not sure if it does on
others, but by setting DP_AUX_MAX_PAYLOAD_BYTES to 1, it fixed reading
the EDID data here and I have 1920x1080 at boot, with valid EDID data.

Not really sure the best way to go about doing that though.  I've poked
at some people in #dri-devel on irc, to see what they think.
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index 2d21253..30d4495 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -9,7 +9,7 @@ 
 	compatible = "google,nyan-big", "nvidia,tegra124";
 
 	panel: panel {
-		compatible = "auo,b133xtn01";
+		compatible = "auo,b133htn01";
 
 		backlight = <&backlight>;
 		ddc-i2c-bus = <&dpaux>;