| Message ID | 1437208027-14584-1-git-send-email-sw@weilnetz.de |
|---|---|
| State | Accepted |
| Headers | show |
On 18 July 2015 at 09:27, Stefan Weil <sw@weilnetz.de> wrote: > Type fprintf_function which fits here was defined with this attribute. > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > > This is an optional trivial patch for 2.4 which fixes compiler warnings > in my build environment (with -Wextra). Reviewed-by: Peter Maydell <peter.maydell@linaro.org> No objection if you want to put it in 2.4, though I'm a bit surprised that missing GCC_FMT_ATTR provokes warnings. The cleanup is nice anyway. thanks -- PMM
On 18 July 2015 at 10:13, Peter Maydell <peter.maydell@linaro.org> wrote: > On 18 July 2015 at 09:27, Stefan Weil <sw@weilnetz.de> wrote: >> Type fprintf_function which fits here was defined with this attribute. >> >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> >> This is an optional trivial patch for 2.4 which fixes compiler warnings >> in my build environment (with -Wextra). > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > No objection if you want to put it in 2.4, though I'm a bit > surprised that missing GCC_FMT_ATTR provokes warnings. > The cleanup is nice anyway. I've applied this to target-arm.next. Thanks. -- PMM
diff --git a/disas/arm-a64.cc b/disas/arm-a64.cc index b0803f9..b57256b 100644 --- a/disas/arm-a64.cc +++ b/disas/arm-a64.cc @@ -42,7 +42,7 @@ public: stream_ = stream; } - void SetPrintf(int (*printf_fn)(FILE *, const char *, ...)) { + void SetPrintf(fprintf_function printf_fn) { printf_ = printf_fn; } @@ -53,7 +53,7 @@ protected: } private: - int (*printf_)(FILE *, const char *, ...); + fprintf_function printf_; FILE *stream_; };
Type fprintf_function which fits here was defined with this attribute. Signed-off-by: Stefan Weil <sw@weilnetz.de> --- This is an optional trivial patch for 2.4 which fixes compiler warnings in my build environment (with -Wextra). disas/arm-a64.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)