Patchwork IDE: pass IRQ flags to the IDE core

login
register
mail settings
Submitter Yegor Yefremov
Date April 8, 2010, 2:26 p.m.
Message ID <q2rf69abfc31004080726scbf96429ub4d84a318835d53d@mail.gmail.com>
Download mbox | patch
Permalink /patch/49733/
State Accepted
Delegated to: David Miller
Headers show

Comments

Yegor Yefremov - April 8, 2010, 2:26 p.m.
IDE: pass IRQ flags to the IDE core

This enables shared IRQs and other features to be used with platform devices

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 15, 2010, 9:16 a.m.
From: Yegor Yefremov <yegorslists@googlemail.com>
Date: Thu, 8 Apr 2010 16:26:29 +0200

> IDE: pass IRQ flags to the IDE core
> 
> This enables shared IRQs and other features to be used with platform devices
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

If you need this for a new device, please use the ATA layer
instead of adding support for new features in IDE which is
in deep maintainence mode only.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Cox - April 15, 2010, 11:07 a.m.
On Thu, 15 Apr 2010 02:16:12 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> Date: Thu, 8 Apr 2010 16:26:29 +0200
> 
> > IDE: pass IRQ flags to the IDE core
> > 
> > This enables shared IRQs and other features to be used with platform devices
> > 
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> 
> If you need this for a new device, please use the ATA layer
> instead of adding support for new features in IDE which is
> in deep maintainence mode only.

Actually Dave I think that one should go in. pata_platform (libata) and
ide_platform both match the same platform objects so you can flip between
them easily (eg for testing work). The fact the IRQ flags are only
honoured in libata but not in the matching IDE driver is probably a good
thing to fix.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 15, 2010, 9:17 p.m.
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 15 Apr 2010 12:07:48 +0100

> On Thu, 15 Apr 2010 02:16:12 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>> Date: Thu, 8 Apr 2010 16:26:29 +0200
>> 
>> > IDE: pass IRQ flags to the IDE core
>> > 
>> > This enables shared IRQs and other features to be used with platform devices
>> > 
>> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> 
>> If you need this for a new device, please use the ATA layer
>> instead of adding support for new features in IDE which is
>> in deep maintainence mode only.
> 
> Actually Dave I think that one should go in. pata_platform (libata) and
> ide_platform both match the same platform objects so you can flip between
> them easily (eg for testing work). The fact the IRQ flags are only
> honoured in libata but not in the matching IDE driver is probably a good
> thing to fix.

Ok, will apply this then.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: b/drivers/ide/ide_platform.c
===================================================================
--- a/drivers/ide/ide_platform.c	2010-04-02 01:02:33.000000000 +0200
+++ b/drivers/ide/ide_platform.c	2010-04-08 16:04:21.000000000 +0200
@@ -95,6 +95,7 @@ 
 	plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);
 	hw.dev = &pdev->dev;

+	d.irq_flags = res_irq->flags;
 	if (mmio)
 		d.host_flags |= IDE_HFLAG_MMIO;
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in