| Message ID | 1437142516-12378-1-git-send-email-joerg.krause@embedded.rocks |
|---|---|
| State | Accepted |
| Headers | show |
Dear Jörg Krause, On Fri, 17 Jul 2015 16:15:16 +0200, Jörg Krause wrote: > Also add reverse dependency for cc-tool. > > Fixes: > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f017442c48244ffd8e/ > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f017442c48244ffd8e/ > http://autobuild.buildroot.net/results/0dd/0dd3ef96bbd034a41d908cdaa6552b27fda78132/ > http://autobuild.buildroot.net/results/34b/34b55b2cd83fd5d87af4a9c15d05094b16ef3960/ > > and many more > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > --- > package/boost/Config.in | 4 ++++ > package/cc-tool/Config.in | 5 +++-- > 2 files changed, 7 insertions(+), 2 deletions(-) Applied, thanks. Thomas
Dear Jörg Krause, On Fri, 17 Jul 2015 16:15:16 +0200, Jörg Krause wrote: > Also add reverse dependency for cc-tool. > > Fixes: > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f017442c48244ffd8e/ > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f017442c48244ffd8e/ > http://autobuild.buildroot.net/results/0dd/0dd3ef96bbd034a41d908cdaa6552b27fda78132/ > http://autobuild.buildroot.net/results/34b/34b55b2cd83fd5d87af4a9c15d05094b16ef3960/ > > and many more > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> Apparently, this isn't sufficient to fix all problems: http://autobuild.buildroot.net/results/49f/49f5c0521fc90fbd4673ad233ff679be007d2953/build-end.log BR2_PACKAGE_BOOST_ARCH_SUPPORTS=y BR2_PACKAGE_BOOST=y BR2_PACKAGE_BOOST_LAYOUT_SYSTEM=y # BR2_PACKAGE_BOOST_LAYOUT_TAGGED is not set # BR2_PACKAGE_BOOST_LAYOUT_VERSIONED is not set BR2_PACKAGE_BOOST_LAYOUT="system" # BR2_PACKAGE_BOOST_ATOMIC is not set BR2_PACKAGE_BOOST_CHRONO=y # BR2_PACKAGE_BOOST_CONTAINER is not set BR2_PACKAGE_BOOST_CONTEXT=y # BR2_PACKAGE_BOOST_DATE_TIME is not set # BR2_PACKAGE_BOOST_EXCEPTION is not set # # boost-filesystem needs a toolchain w/ wchar # # BR2_PACKAGE_BOOST_GRAPH is not set # BR2_PACKAGE_BOOST_GRAPH_PARALLEL is not set # BR2_PACKAGE_BOOST_IOSTREAMS is not set # # boost-locale needs a toolchain w/ wchar # # BR2_PACKAGE_BOOST_MATH is not set # BR2_PACKAGE_BOOST_MPI is not set # BR2_PACKAGE_BOOST_PROGRAM_OPTIONS is not set # BR2_PACKAGE_BOOST_RANDOM is not set # BR2_PACKAGE_BOOST_REGEX is not set BR2_PACKAGE_BOOST_SERIALIZATION=y # BR2_PACKAGE_BOOST_SIGNALS is not set # BR2_PACKAGE_BOOST_SYSTEM is not set # BR2_PACKAGE_BOOST_TEST is not set # BR2_PACKAGE_BOOST_THREAD is not set # BR2_PACKAGE_BOOST_TIMER is not set # BR2_PACKAGE_BOOST_WAVE is not set Maybe we should make the entire boost package depends on wchar and be done with it? Thomas
Dear Thomas, On Mi, 2015-07-22 at 08:55 +0200, Thomas Petazzoni wrote: > Dear Jörg Krause, > > On Fri, 17 Jul 2015 16:15:16 +0200, Jörg Krause wrote: > > Also add reverse dependency for cc-tool. > > > > Fixes: > > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f0 > > 17442c48244ffd8e/ > > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f0 > > 17442c48244ffd8e/ > > http://autobuild.buildroot.net/results/0dd/0dd3ef96bbd034a41d908cda > > a6552b27fda78132/ > > http://autobuild.buildroot.net/results/34b/34b55b2cd83fd5d87af4a9c1 > > 5d05094b16ef3960/ > > > > and many more > > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > Apparently, this isn't sufficient to fix all problems: > > http://autobuild.buildroot.net/results/49f/49f5c0521fc90fbd4673ad23 > 3ff679be007d2953/build-end.log > > > Maybe we should make the entire boost package depends on wchar and be > done with it? I will check a build with all boost modules enabled. If there are too many depending on wchar, let's say more then four or five, we can do it this way. Best regards Jörg Krause
Dear Thomas Petazzoni, On Mi, 2015-07-22 at 08:55 +0200, Thomas Petazzoni wrote: > Dear Jörg Krause, > > On Fri, 17 Jul 2015 16:15:16 +0200, Jörg Krause wrote: > > Also add reverse dependency for cc-tool. > > > > Fixes: > > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f0 > > 17442c48244ffd8e/ > > http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f0 > > 17442c48244ffd8e/ > > http://autobuild.buildroot.net/results/0dd/0dd3ef96bbd034a41d908cda > > a6552b27fda78132/ > > http://autobuild.buildroot.net/results/34b/34b55b2cd83fd5d87af4a9c1 > > 5d05094b16ef3960/ > > > > and many more > > > > Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> > > Apparently, this isn't sufficient to fix all problems: > > http://autobuild.buildroot.net/results/49f/49f5c0521fc90fbd4673ad23 > 3ff679be007d2953/build-end.log > > Maybe we should make the entire boost package depends on wchar and be > done with it? There are a lot more then five boost modules needing wchar. If we make boost depending on wchar we add reverse dependencies to some packages which could be build without wchar before. What do you think? Best regards Jörg Krause
Dear Jörg Krause, On Thu, 23 Jul 2015 09:18:13 +0200, Jörg Krause wrote: > There are a lot more then five boost modules needing wchar. If we make > boost depending on wchar we add reverse dependencies to some packages > which could be build without wchar before. > > What do you think? * cc-tool -> already depends on wchar * gnuradio -> already depends on wchar * kodi -> already depends on wchar * libftdi1 -> does not depend on wchar yet, but only the C++ bindings of libftdi1 need boost, so I think it's OK * mpd -> already depends on wchar * pulseview -> already depends on wchar * python-libconfig -> already depends on wchar since it depends on python or python3, and both depend on wchar * thrift -> already depends on wchar * yaml-cpp -> would add a wchar dependency * zmpqq -> already depends on wchar So the only affected packages are the C++ bindings of libftdi1 and yaml-cpp. Conclusion: I believe it's reasonable to add a wchar dependency globally to boost. It's a pain to keep track which sub-option of boost needs or does not need wchar, and boost is a "big" thing, so having an additional toolchain dependency that is nevertheless already very common, is not a big issue. Thanks! Thomas
diff --git a/package/boost/Config.in b/package/boost/Config.in index 92d59c2..68004b6 100644 --- a/package/boost/Config.in +++ b/package/boost/Config.in @@ -77,6 +77,10 @@ config BR2_PACKAGE_BOOST_EXCEPTION config BR2_PACKAGE_BOOST_FILESYSTEM bool "boost-filesystem" + depends on BR2_USE_WCHAR + +comment "boost-filesystem needs a toolchain w/ wchar" + depends on !BR2_USE_WCHAR config BR2_PACKAGE_BOOST_GRAPH bool "boost-graph" diff --git a/package/cc-tool/Config.in b/package/cc-tool/Config.in index be11599..f8e4531 100644 --- a/package/cc-tool/Config.in +++ b/package/cc-tool/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_CC_TOOL depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS + depends on BR2_USE_WCHAR # boost-filesystem select BR2_PACKAGE_LIBUSB select BR2_PACKAGE_BOOST select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS @@ -17,6 +18,6 @@ config BR2_PACKAGE_CC_TOOL http://sourceforge.net/projects/cctool/ -comment "cc-tool needs a toolchain w/ C++, threads" +comment "cc-tool needs a toolchain w/ C++, threads, wchar" depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
Also add reverse dependency for cc-tool. Fixes: http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f017442c48244ffd8e/ http://autobuild.buildroot.net/results/2c7/2c7783b7f3cc28d54d15a7f017442c48244ffd8e/ http://autobuild.buildroot.net/results/0dd/0dd3ef96bbd034a41d908cdaa6552b27fda78132/ http://autobuild.buildroot.net/results/34b/34b55b2cd83fd5d87af4a9c15d05094b16ef3960/ and many more Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks> --- package/boost/Config.in | 4 ++++ package/cc-tool/Config.in | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-)