| Message ID | 1437078976-29145-1-git-send-email-laurent.navet@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Jul 16, 2015 at 10:36:16PM +0200, Laurent Navet wrote: > ret is assigned zero and just used to return. remove it. > Found by using coccinelle. > > Signed-off-by: Laurent Navet <laurent.navet@gmail.com> Why not make it void?
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 50bfd8c..cf3c6c0 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -409,7 +409,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) { unsigned long tmp; unsigned char byte; - int ret = 0; switch (i2c->state) { @@ -565,7 +564,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) tmp &= ~S3C2410_IICCON_IRQPEND; writel(tmp, i2c->regs + S3C2410_IICCON); out: - return ret; + return 0; } /* s3c24xx_i2c_irq
ret is assigned zero and just used to return. remove it. Found by using coccinelle. Signed-off-by: Laurent Navet <laurent.navet@gmail.com> --- drivers/i2c/busses/i2c-s3c2410.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)