| Message ID | 1437073704-13881-1-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On Thu, Jul 16, 2015 at 9:08 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > This variable is not modified in the driver and all functions it it > passed to don't change it either. So it can and should be marked const. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Patch applied. I'll push the tree later today, pls verify that your diacritics look right now! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Linus, On Mon, Jul 27, 2015 at 12:21:26PM +0200, Linus Walleij wrote: > On Thu, Jul 16, 2015 at 9:08 PM, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > > This variable is not modified in the driver and all functions it it > > passed to don't change it either. So it can and should be marked const. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Patch applied. > > I'll push the tree later today, pls verify that your diacritics look > right now! It's not urgent, right? (i.e. you pushed for inclusion in next, not for the other Linus.) Then I have a script that will catch you :-) Best regards Uwe
On Mon, Jul 27, 2015 at 2:32 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: >> I'll push the tree later today, pls verify that your diacritics look >> right now! > > It's not urgent, right? Nope... Ah, I mean check I got it RIGHT now, not check that RIGHT NOW, hehehhhh. > (i.e. you pushed for inclusion in next, not for > the other Linus.) Then I have a script that will catch you :-) Awesome, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index da8e89205f37..0e2dbbb1645b 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -334,7 +334,7 @@ static const struct irq_domain_ops mpc8xxx_gpio_irq_ops = { .xlate = irq_domain_xlate_twocell, }; -static struct of_device_id mpc8xxx_gpio_ids[] = { +static const struct of_device_id mpc8xxx_gpio_ids[] = { { .compatible = "fsl,mpc8349-gpio", }, { .compatible = "fsl,mpc8572-gpio", }, { .compatible = "fsl,mpc8610-gpio", },
This variable is not modified in the driver and all functions it it passed to don't change it either. So it can and should be marked const. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/gpio/gpio-mpc8xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)