From patchwork Wed Apr 7 18:25:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 49636 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4E048B7D0E for ; Thu, 8 Apr 2010 04:49:45 +1000 (EST) Received: from localhost ([127.0.0.1]:53563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzaJL-0005y4-Ux for incoming@patchwork.ozlabs.org; Wed, 07 Apr 2010 14:49:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NzZwU-0000Ma-9Z for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:34 -0400 Received: from [140.186.70.92] (port=43699 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NzZwP-0000Km-ED for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NzZwL-0003fa-D0 for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63930) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NzZwJ-0003em-Fu for qemu-devel@nongnu.org; Wed, 07 Apr 2010 14:25:24 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o37IPMnl021075 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Apr 2010 14:25:22 -0400 Received: from localhost (vpn-8-238.rdu.redhat.com [10.11.8.238]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o37IPLOW021821; Wed, 7 Apr 2010 14:25:22 -0400 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Wed, 7 Apr 2010 15:25:08 -0300 Message-Id: <1270664710-3948-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1270664710-3948-1-git-send-email-lcapitulino@redhat.com> References: <1270664710-3948-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: armbru@redhat.com Subject: [Qemu-devel] [PATCH 2/4] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only for two problems: the input is not an object or the "execute" key is missing. Signed-off-by: Luiz Capitulino --- monitor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 709b326..cd350d6 100644 --- a/monitor.c +++ b/monitor.c @@ -4489,7 +4489,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens) qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "execute"); goto err_input; } else if (qobject_type(obj) != QTYPE_QSTRING) { - qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "string"); + qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "execute", "string"); goto err_input; }