Patchwork [2/4] QMP: Use QERR_QMP_BAD_INPUT_OBJECT_MEMBER

login
register
mail settings
Submitter Luiz Capitulino
Date April 7, 2010, 6:25 p.m.
Message ID <1270664710-3948-3-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/49636/
State New
Headers show

Comments

Luiz Capitulino - April 7, 2010, 6:25 p.m.
The QERR_QMP_BAD_INPUT_OBJECT error is going to be used only
for two problems: the input is not an object or the "execute"
key is missing.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/monitor.c b/monitor.c
index 709b326..cd350d6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4489,7 +4489,7 @@  static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
         qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "execute");
         goto err_input;
     } else if (qobject_type(obj) != QTYPE_QSTRING) {
-        qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "string");
+        qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "execute", "string");
         goto err_input;
     }