From patchwork Wed Jul 15 09:52:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Khlebnikov X-Patchwork-Id: 495741 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9852C1402BC for ; Wed, 15 Jul 2015 20:00:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru header.b=ZVs2OobW; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754589AbbGOKAP (ORCPT ); Wed, 15 Jul 2015 06:00:15 -0400 Received: from forward-corp1o.mail.yandex.net ([37.140.190.172]:59590 "EHLO forward-corp1o.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754585AbbGOKAL (ORCPT ); Wed, 15 Jul 2015 06:00:11 -0400 X-Greylist: delayed 485 seconds by postgrey-1.27 at vger.kernel.org; Wed, 15 Jul 2015 06:00:10 EDT Received: from smtpcorp4.mail.yandex.net (smtpcorp4.mail.yandex.net [95.108.252.2]) by forward-corp1o.mail.yandex.net (Yandex) with ESMTP id 653D83921095; Wed, 15 Jul 2015 12:52:02 +0300 (MSK) Received: from smtpcorp4.mail.yandex.net (localhost [127.0.0.1]) by smtpcorp4.mail.yandex.net (Yandex) with ESMTP id D9BFE2C031E; Wed, 15 Jul 2015 12:52:01 +0300 (MSK) Received: from unknown (unknown [2a02:6b8:0:408:55be:d924:24e7:8b42]) by smtpcorp4.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 4cubY449GE-q1seEJQU; Wed, 15 Jul 2015 12:52:01 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1436953921; bh=huEvjIDERXXEwAdDAZ6Co3z83BTXcSW2eNUdmqsTGQg=; h=Subject:From:To:Cc:Date:Message-ID:User-Agent:MIME-Version: Content-Type:Content-Transfer-Encoding; b=ZVs2OobWXbWh2JVEmlNbTMvnNEzCXBeEiJ/mmJynjlnH6OMkQ+Wx4wxMz14nAAdut +ySv8FIHmfsaN04FRhPK6plCkWhUXdkDYOBA2LOLE5c8GwV5mykssFc8NBoblWD7k+ E7it9RigjOicfoPrQ3QvneCzvKyVKgSFZ5lI9NNI= Authentication-Results: smtpcorp4.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Subject: [PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched() From: Konstantin Khlebnikov To: Peter Zijlstra Cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Alexander Graf , Paul Mackerras , David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky , linuxppc-dev@lists.ozlabs.org Date: Wed, 15 Jul 2015 12:52:01 +0300 Message-ID: <20150715095201.12246.49283.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org This code is used only when CONFIG_PREEMPT=n and only in non-atomic context: xen_in_preemptible_hcall is set only in privcmd_ioctl_hypercall(). Thus preempt_count is zero and should_resched() is equal to need_resched(). Signed-off-by: Konstantin Khlebnikov --- drivers/xen/preempt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/xen/preempt.c b/drivers/xen/preempt.c index a1800c150839..08cb419eb4e6 100644 --- a/drivers/xen/preempt.c +++ b/drivers/xen/preempt.c @@ -31,7 +31,7 @@ EXPORT_SYMBOL_GPL(xen_in_preemptible_hcall); asmlinkage __visible void xen_maybe_preempt_hcall(void) { if (unlikely(__this_cpu_read(xen_in_preemptible_hcall) - && should_resched())) { + && need_resched())) { /* * Clear flag as we may be rescheduled on a different * cpu.