| Message ID | 20150715092915.GA8262@intel-desktop |
|---|---|
| State | Accepted |
| Headers | show |
[+cc Aaron] On Wed, Jul 15, 2015 at 02:59:46PM +0530, Srinidhi Kasagar wrote: > The function takes ACPI handle, not the device itself. Fix the > comment > > Signed-off-by: Srinidhi Kasagar <srinidhi.kasagar@intel.com> Applied to pci/misc for v4.3, thanks! > --- > Add this as part of your trivial commenting fixes patch series > > drivers/pci/pci-acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c > index 6f6f175f51f7..d2e2bf4ef0a4 100644 > --- a/drivers/pci/pci-acpi.c > +++ b/drivers/pci/pci-acpi.c > @@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev) > /** > * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI > * @pdev: the PCI device whose delay is to be updated > - * @adev: the companion ACPI device of this PCI device > + * @handle: ACPI handle of this device > * > * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM > * control method of either the device itself or the PCI host bridge. > -- > 1.7.9.5 > > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/16/2015 04:14 AM, Bjorn Helgaas wrote: > [+cc Aaron] > > On Wed, Jul 15, 2015 at 02:59:46PM +0530, Srinidhi Kasagar wrote: >> The function takes ACPI handle, not the device itself. Fix the >> comment I must have overlooked the comment while changing the function prototype, thanks for the fix! Regards, Aaron >> >> Signed-off-by: Srinidhi Kasagar <srinidhi.kasagar@intel.com> > > Applied to pci/misc for v4.3, thanks! > >> --- >> Add this as part of your trivial commenting fixes patch series >> >> drivers/pci/pci-acpi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c >> index 6f6f175f51f7..d2e2bf4ef0a4 100644 >> --- a/drivers/pci/pci-acpi.c >> +++ b/drivers/pci/pci-acpi.c >> @@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev) >> /** >> * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI >> * @pdev: the PCI device whose delay is to be updated >> - * @adev: the companion ACPI device of this PCI device >> + * @handle: ACPI handle of this device >> * >> * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM >> * control method of either the device itself or the PCI host bridge. >> -- >> 1.7.9.5 >> >> >> -- -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c index 6f6f175f51f7..d2e2bf4ef0a4 100644 --- a/drivers/pci/pci-acpi.c +++ b/drivers/pci/pci-acpi.c @@ -594,7 +594,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev) /** * pci_acpi_optimize_delay - optimize PCI D3 and D3cold delay from ACPI * @pdev: the PCI device whose delay is to be updated - * @adev: the companion ACPI device of this PCI device + * @handle: ACPI handle of this device * * Update the d3_delay and d3cold_delay of a PCI device from the ACPI _DSM * control method of either the device itself or the PCI host bridge.
The function takes ACPI handle, not the device itself. Fix the comment Signed-off-by: Srinidhi Kasagar <srinidhi.kasagar@intel.com> --- Add this as part of your trivial commenting fixes patch series drivers/pci/pci-acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)