Patchwork [v2] cleanup block driver option handling in vl.c

login
register
mail settings
Submitter Christoph Hellwig
Date April 6, 2010, 5:12 p.m.
Message ID <20100406171204.GA10881@lst.de>
Download mbox | patch
Permalink /patch/49532/
State New
Headers show

Comments

Christoph Hellwig - April 6, 2010, 5:12 p.m.
Assign directly to the bdrv_flags variable instead of using
magic numbers before translating to the BDRV_O_* options.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Kevin Wolf - April 7, 2010, 8:41 a.m.
Am 06.04.2010 19:12, schrieb Christoph Hellwig:
> Assign directly to the bdrv_flags variable instead of using
> magic numbers before translating to the BDRV_O_* options.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good now.

Acked-by: Kevin Wolf <kwolf@redhat.com>

Patch

Index: qemu/vl.c
===================================================================
--- qemu.orig/vl.c	2010-04-06 19:05:52.403004388 +0200
+++ qemu/vl.c	2010-04-06 19:07:28.402006066 +0200
@@ -851,10 +851,8 @@  DriveInfo *drive_init(QemuOpts *opts, vo
     QEMUMachine *machine = opaque;
     int max_devs;
     int index;
-    int cache;
-    int aio = 0;
     int ro = 0;
-    int bdrv_flags;
+    int bdrv_flags = 0;
     int on_read_error, on_write_error;
     const char *devaddr;
     DriveInfo *dinfo;
@@ -863,7 +861,6 @@  DriveInfo *drive_init(QemuOpts *opts, vo
     *fatal_error = 1;
 
     translation = BIOS_ATA_TRANSLATION_AUTO;
-    cache = 1;
 
     if (machine && machine->use_scsi) {
         type = IF_SCSI;
@@ -977,13 +974,13 @@  DriveInfo *drive_init(QemuOpts *opts, vo
     }
 
     if ((buf = qemu_opt_get(opts, "cache")) != NULL) {
-        if (!strcmp(buf, "off") || !strcmp(buf, "none"))
-            cache = 0;
-        else if (!strcmp(buf, "writethrough"))
-            cache = 1;
-        else if (!strcmp(buf, "writeback"))
-            cache = 2;
-        else {
+        if (!strcmp(buf, "off") || !strcmp(buf, "none")) {
+            bdrv_flags |= BDRV_O_NOCACHE;
+        } else if (!strcmp(buf, "writeback")) {
+            bdrv_flags |= BDRV_O_CACHE_WB;
+        } else if (!strcmp(buf, "writethrough")) {
+            /* this is the default */
+        } else {
            fprintf(stderr, "qemu: invalid cache option\n");
            return NULL;
         }
@@ -991,11 +988,11 @@  DriveInfo *drive_init(QemuOpts *opts, vo
 
 #ifdef CONFIG_LINUX_AIO
     if ((buf = qemu_opt_get(opts, "aio")) != NULL) {
-        if (!strcmp(buf, "threads"))
-            aio = 0;
-        else if (!strcmp(buf, "native"))
-            aio = 1;
-        else {
+        if (!strcmp(buf, "native")) {
+            bdrv_flags |= BDRV_O_NATIVE_AIO;
+        } else if (!strcmp(buf, "threads")) {
+            /* this is the default */
+        } else {
            fprintf(stderr, "qemu: invalid aio option\n");
            return NULL;
         }
@@ -1169,20 +1166,10 @@  DriveInfo *drive_init(QemuOpts *opts, vo
         *fatal_error = 0;
         return NULL;
     }
-    bdrv_flags = 0;
     if (snapshot) {
-        bdrv_flags |= BDRV_O_SNAPSHOT;
-        cache = 2; /* always use write-back with snapshot */
-    }
-    if (cache == 0) /* no caching */
-        bdrv_flags |= BDRV_O_NOCACHE;
-    else if (cache == 2) /* write-back */
-        bdrv_flags |= BDRV_O_CACHE_WB;
-
-    if (aio == 1) {
-        bdrv_flags |= BDRV_O_NATIVE_AIO;
-    } else {
-        bdrv_flags &= ~BDRV_O_NATIVE_AIO;
+        /* always use write-back with snapshot */
+        bdrv_flags &= ~BDRV_O_CACHE_MASK;
+        bdrv_flags |= (BDRV_O_SNAPSHOT|BDRV_O_CACHE_WB);
     }
 
     if (ro == 1) {