From patchwork Tue Apr 6 11:44:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 49507 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 903E2B7D0E for ; Tue, 6 Apr 2010 22:08:31 +1000 (EST) Received: from localhost ([127.0.0.1]:35596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nz7UN-0005Ft-Ju for incoming@patchwork.ozlabs.org; Tue, 06 Apr 2010 08:02:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nz7Eh-0000qv-5h for qemu-devel@nongnu.org; Tue, 06 Apr 2010 07:46:27 -0400 Received: from [140.186.70.92] (port=47372 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nz7Ef-0000qm-QU for qemu-devel@nongnu.org; Tue, 06 Apr 2010 07:46:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nz7Ee-0000RY-9Z for qemu-devel@nongnu.org; Tue, 06 Apr 2010 07:46:25 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:56646) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nz7Ed-0000RO-QS for qemu-devel@nongnu.org; Tue, 06 Apr 2010 07:46:24 -0400 Received: from flocke.weilnetz.de (p54ADF876.dip.t-dialin.net [84.173.248.118]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0M6yZd-1Ne7uQ1ARh-00x4Ts; Tue, 06 Apr 2010 13:46:11 +0200 Received: from stefan by flocke.weilnetz.de with local (Exim 4.71) (envelope-from ) id 1Nz7E6-00084Y-G7; Tue, 06 Apr 2010 13:45:50 +0200 From: Stefan Weil To: QEMU Developers Date: Tue, 6 Apr 2010 13:44:09 +0200 Message-Id: <1270554249-24861-10-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.0 In-Reply-To: <1270554249-24861-1-git-send-email-weil@mail.berlios.de> References: <1270554249-24861-1-git-send-email-weil@mail.berlios.de> X-Provags-ID: V01U2FsdGVkX19r72An8/qGbMFKsRQZCo4/JR0yBBJT8GkOl9c 9lkT4vcKDlbi8wWJ4Z7cu9DKBZ/Yru2NN+8CrjIV7XpXUup1JQ W23dwefxe5dIef7VTrOfKmlGRyU5JbEDzZ0Aw3nLrDMxBNg/EH jhA== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH 9/9] eepro100: Fix PCI interrupt pin configuration regression X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Commit 15e89f5916c9e82347cbd1fd416db3e348bab426 removed this setting, but it is still needed. Without this patch, e100 device drivers using interrupts don't work with qemu. See other nic emulations which also set the PCI interrupt pin. Signed-off-by: Stefan Weil --- hw/eepro100.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index 2401888..bc7e3f1 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -475,6 +475,10 @@ static void e100_pci_reset(EEPRO100State * s, E100PCIDeviceInfo *e100_device) /* PCI Latency Timer */ pci_set_byte(pci_conf + PCI_LATENCY_TIMER, 0x20); /* latency timer = 32 clocks */ /* Capability Pointer is set by PCI framework. */ + /* Interrupt Line */ + /* Interrupt Pin */ + /* TODO: RST# value should be 0. */ + pci_set_byte(pci_conf + PCI_INTERRUPT_PIN, 1); /* interrupt pin 0 */ /* Minimum Grant */ pci_set_byte(pci_conf + PCI_MIN_GNT, 0x08); /* Maximum Latency */