Patchwork Add KVM CFLAGS to vhost build

login
register
mail settings
Submitter Jan Kiszka
Date April 6, 2010, 11:31 a.m.
Message ID <4BBB1B91.90805@siemens.com>
Download mbox | patch
Permalink /patch/49495/
State New
Headers show

Comments

Jan Kiszka - April 6, 2010, 11:31 a.m.
The configure test of vhost uses KVM CFLAGS, so the build must use them
as well. Otherwise we specifically miss what --kerneldir provides.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 Makefile.target |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jan Kiszka - May 3, 2010, 5:03 p.m.
Jan Kiszka wrote:
> The configure test of vhost uses KVM CFLAGS, so the build must use them
> as well. Otherwise we specifically miss what --kerneldir provides.
> 

Ping.

Jan

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  Makefile.target |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 45cbe56..6fc3034 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
>  
>  LIBS+=-lm
>  
> -kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> +kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
>  
>  config-target.h: config-target.h-timestamp
>  config-target.h-timestamp: config-target.mak
> 
> 
>
Michael S. Tsirkin - May 3, 2010, 5:21 p.m.
On Tue, Apr 06, 2010 at 01:31:29PM +0200, Jan Kiszka wrote:
> The configure test of vhost uses KVM CFLAGS, so the build must use them
> as well. Otherwise we specifically miss what --kerneldir provides.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  Makefile.target |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile.target b/Makefile.target
> index 45cbe56..6fc3034 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
>  
>  LIBS+=-lm
>  
> -kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> +kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
>  
>  config-target.h: config-target.h-timestamp
>  config-target.h-timestamp: config-target.mak
Anthony Liguori - May 3, 2010, 6:05 p.m.
On 04/06/2010 06:31 AM, Jan Kiszka wrote:
> The configure test of vhost uses KVM CFLAGS, so the build must use them
> as well. Otherwise we specifically miss what --kerneldir provides.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@siemens.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   Makefile.target |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.target b/Makefile.target
> index 45cbe56..6fc3034 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -32,7 +32,7 @@ PROGS=$(QEMU_PROG)
>
>   LIBS+=-lm
>
> -kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
> +kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
>
>   config-target.h: config-target.h-timestamp
>   config-target.h-timestamp: config-target.mak
>
>
>
>

Patch

diff --git a/Makefile.target b/Makefile.target
index 45cbe56..6fc3034 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -32,7 +32,7 @@  PROGS=$(QEMU_PROG)
 
 LIBS+=-lm
 
-kvm.o kvm-all.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
+kvm.o kvm-all.o vhost.o vhost_net.o: QEMU_CFLAGS+=$(KVM_CFLAGS)
 
 config-target.h: config-target.h-timestamp
 config-target.h-timestamp: config-target.mak