diff mbox

[v3,3/3] util-linux: put package options in a sub-menu

Message ID 1436842628-29469-3-git-send-email-danomimanchego123@gmail.com
State Accepted
Headers show

Commit Message

Danomi Manchego July 14, 2015, 2:57 a.m. UTC
Hide all the util-linux options in a menuconfig, as the option
list is quite long.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/util-linux/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vicente Olivert Riera Sept. 14, 2015, 12:37 p.m. UTC | #1
Dear Danomi Manchego,

On 07/14/2015 03:57 AM, Danomi Manchego wrote:
> Hide all the util-linux options in a menuconfig, as the option
> list is quite long.

I also think the list is quite long and util-linux deserves its own submenu.

> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

I checked that util-linux option is actually converted into a submenu:

[*] util-linux  --->

Regards,

Vincent.

> ---
>  package/util-linux/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
> index 042cae0..c8d16d2 100644
> --- a/package/util-linux/Config.in
> +++ b/package/util-linux/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_UTIL_LINUX
> +menuconfig BR2_PACKAGE_UTIL_LINUX
>  	bool "util-linux"
>  	depends on BR2_USE_WCHAR
>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
>
Yann E. MORIN Jan. 19, 2016, 8:16 p.m. UTC | #2
Danomi, All,

On 2015-07-13 22:57 -0400, Danomi Manchego spake thusly:
> Hide all the util-linux options in a menuconfig, as the option
> list is quite long.
> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/util-linux/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
> index 042cae0..c8d16d2 100644
> --- a/package/util-linux/Config.in
> +++ b/package/util-linux/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_UTIL_LINUX
> +menuconfig BR2_PACKAGE_UTIL_LINUX
>  	bool "util-linux"
>  	depends on BR2_USE_WCHAR
>  	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Jan. 19, 2016, 8:23 p.m. UTC | #3
Dear Danomi Manchego,

On Mon, 13 Jul 2015 22:57:08 -0400, Danomi Manchego wrote:
> Hide all the util-linux options in a menuconfig, as the option
> list is quite long.
> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/util-linux/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
index 042cae0..c8d16d2 100644
--- a/package/util-linux/Config.in
+++ b/package/util-linux/Config.in
@@ -1,4 +1,4 @@ 
-config BR2_PACKAGE_UTIL_LINUX
+menuconfig BR2_PACKAGE_UTIL_LINUX
 	bool "util-linux"
 	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE