diff mbox

[gomp] Move openacc vector& worker single handling to RTL

Message ID 877fq41epd.fsf@kepler.schwinge.homeip.net
State New
Headers show

Commit Message

Thomas Schwinge July 13, 2015, 11:26 a.m. UTC 
Hi!

On Fri, 10 Jul 2015 11:04:14 +0200, I wrote:
> On Thu, 09 Jul 2015 20:25:22 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> > This is the patch I committed.

> 2. Don't be shy to remove a bunch of XFAILs, in fact all :-) of those
> remaining from the test cases that Julian had added in
> <http://news.gmane.org/find-root.php?message_id=%3C20150617151515.087aa93e%40octopus%3E>.
> 
> Unfortunately, there's also one regressions, but I'm seeing it only on
> Nvidia K20 hardware, not on my laptop (but it may well be
> hardware-dependent: according to a web search, CUDA error 716 translates
> to CUDA_ERROR_MISALIGNED_ADDRESS).  Are you reproducing that one, and/or
> do you have an idea where it's coming from?

Are you looking into this, or should somebody else?


Also, this one:

> --- libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c
> +++ libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c
> @@ -1,5 +1,3 @@
> -/* { dg-xfail-run-if "TODO" { openacc_nvidia_accel_selected } { "*" } { "" } } */
> -
>  #include <assert.h>
>  
>  /* Test of gang-private array variable declared on loop directive, with

... in fact still FAILs for acc_device_nvidia (maybe I've just been lucky
when I first tested your patch/commit?), so that's another thing to look
into; committed in r225733:

commit 79234191653398a5897ca9be0f28af417e1ad212
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Mon Jul 13 11:23:13 2015 +0000

    libgomp: XFAIL libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c for acc_device_nvidia
    
        private-vars-loop-gang-5.exe: [...]/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c:29: main: Assertion `arr[i] == i + (i % 8) * 2' failed.
    
    	libgomp/
    	* testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c:
    	Add XFAIL.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225733 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog.gomp                                               | 5 +++++
 .../testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c   | 3 +++
 2 files changed, 8 insertions(+)



Grüße,
 Thomas

Comments

Nathan Sidwell July 13, 2015, 1:23 p.m. UTC | #1 
On 07/13/15 07:26, Thomas Schwinge wrote:
> Hi!
>
> On Fri, 10 Jul 2015 11:04:14 +0200, I wrote:
>> On Thu, 09 Jul 2015 20:25:22 -0400, Nathan Sidwell <nathan@acm.org> wrote:
>>> This is the patch I committed.
>
>> 2. Don't be shy to remove a bunch of XFAILs, in fact all :-) of those
>> remaining from the test cases that Julian had added in
>> <http://news.gmane.org/find-root.php?message_id=%3C20150617151515.087aa93e%40octopus%3E>.
>>
>> Unfortunately, there's also one regressions, but I'm seeing it only on
>> Nvidia K20 hardware, not on my laptop (but it may well be
>> hardware-dependent: according to a web search, CUDA error 716 translates
>> to CUDA_ERROR_MISALIGNED_ADDRESS).  Are you reproducing that one, and/or
>> do you have an idea where it's coming from?
>
> Are you looking into this, or should somebody else?

I'm not looking at any regressions because I  wasn't aware of any.

nathan
diff mbox

Patch

diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp
index 6ee00be..fd7887a 100644
--- libgomp/ChangeLog.gomp
+++ libgomp/ChangeLog.gomp
@@ -1,3 +1,8 @@ 
+2015-07-13  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c:
+	Add XFAIL.
+
 2015-07-12  Tom de Vries  <tom@codesourcery.com>
 
 	* testsuite/libgomp.oacc-c-c++-common/kernels-loop-nest.c: New test.
diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c
index b070773..a710849 100644
--- libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c
@@ -1,3 +1,6 @@ 
+/* main: Assertion `arr[i] == i + (i % 8) * 2' failed.
+   { dg-xfail-run-if "TODO" { openacc_nvidia_accel_selected } { "*" } { "" } } */
+
 #include <assert.h>
 
 /* Test of gang-private array variable declared on loop directive, with