From patchwork Mon Apr 5 20:33:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 49445 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 904DBB7D0D for ; Tue, 6 Apr 2010 07:16:56 +1000 (EST) Received: from localhost ([127.0.0.1]:44626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nyt3e-0001uw-NE for incoming@patchwork.ozlabs.org; Mon, 05 Apr 2010 16:38:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nyt0h-0001Yf-3E for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:35:03 -0400 Received: from [140.186.70.92] (port=49403 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nyt0a-0001WI-70 for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nyszv-0001Zo-PK for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:34:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55620) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nyszv-0001Zi-He for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:34:15 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o35KYEAG030312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Apr 2010 16:34:14 -0400 Received: from localhost (vpn-8-191.rdu.redhat.com [10.11.8.191]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o35KYDx8029456; Mon, 5 Apr 2010 16:34:14 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Mon, 5 Apr 2010 17:33:42 -0300 Message-Id: <1270499642-31543-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com> References: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Luiz Capitulino , qemu-devel@nongnu.org, Markus Armbruster Subject: [Qemu-devel] [PATCH 01/21] qdev: Convert qdev_unplug() to QError X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Markus Armbruster Note: our device unplug methods don't need conversion work, because they can't currently fail. Signed-off-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- hw/qdev.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 17a46a7..0612dc0 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -287,8 +287,7 @@ int qdev_init(DeviceState *dev) int qdev_unplug(DeviceState *dev) { if (!dev->parent_bus->allow_hotplug) { - error_report("Bus %s does not support hotplugging", - dev->parent_bus->name); + qerror_report(QERR_BUS_NO_HOTPLUG, dev->parent_bus->name); return -1; } assert(dev->info->unplug != NULL);