Patchwork [01/21] qdev: Convert qdev_unplug() to QError

login
register
mail settings
Submitter Luiz Capitulino
Date April 5, 2010, 8:33 p.m.
Message ID <1270499642-31543-2-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/49445/
State New
Headers show

Comments

Luiz Capitulino - April 5, 2010, 8:33 p.m.
From: Markus Armbruster <armbru@redhat.com>

Note: our device unplug methods don't need conversion work, because
they can't currently fail.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 hw/qdev.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Patch

diff --git a/hw/qdev.c b/hw/qdev.c
index 17a46a7..0612dc0 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -287,8 +287,7 @@  int qdev_init(DeviceState *dev)
 int qdev_unplug(DeviceState *dev)
 {
     if (!dev->parent_bus->allow_hotplug) {
-        error_report("Bus %s does not support hotplugging",
-                     dev->parent_bus->name);
+        qerror_report(QERR_BUS_NO_HOTPLUG, dev->parent_bus->name);
         return -1;
     }
     assert(dev->info->unplug != NULL);