Patchwork [1/1] PCI quirks: disable msi on AMD rs4xx internal gfx bridges

login
register
mail settings
Submitter Chase Douglas
Date April 5, 2010, 6:35 p.m.
Message ID <1270492541-20200-2-git-send-email-chase.douglas@canonical.com>
Download mbox | patch
Permalink /patch/49419/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Chase Douglas - April 5, 2010, 6:35 p.m.
From: Alex Deucher <alexdeucher@gmail.com>

Doesn't seem to work reliably for gfx.  See kernel bug
15626.

Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
Cc: Stable <stable@kernel.org>

BugLink: http://bugs.launchpad.net/bugs/509273

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/pci/quirks.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Leann Ogasawara - April 5, 2010, 6:56 p.m.
On Mon, 2010-04-05 at 14:35 -0400, Chase Douglas wrote:
> From: Alex Deucher <alexdeucher@gmail.com>
> 
> Doesn't seem to work reliably for gfx.  See kernel bug
> 15626.
> 
> Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> Cc: Stable <stable@kernel.org>
> 
> BugLink: http://bugs.launchpad.net/bugs/509273
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>

Seems this is very low risk of regression and it has confirmation in the
launchpad bug from the original bug reporter to resolve the issue.

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

> ---
>  drivers/pci/quirks.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 245d2cd..8c6eb85 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2092,6 +2092,7 @@ static void __devinit quirk_disable_msi(struct pci_dev *dev)
>  	}
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x5a3f, quirk_disable_msi);
>  
>  /* Go through the list of Hypertransport capabilities and
>   * return 1 if a HT MSI capability is found and enabled */
> -- 
> 1.7.0
> 
>
Andy Whitcroft - April 8, 2010, 6:07 p.m.
On Mon, Apr 05, 2010 at 02:35:41PM -0400, Chase Douglas wrote:
> From: Alex Deucher <alexdeucher@gmail.com>
> 
> Doesn't seem to work reliably for gfx.  See kernel bug
> 15626.
> 
> Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> Cc: Stable <stable@kernel.org>
> 
> BugLink: http://bugs.launchpad.net/bugs/509273
> 
> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> ---
>  drivers/pci/quirks.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 245d2cd..8c6eb85 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2092,6 +2092,7 @@ static void __devinit quirk_disable_msi(struct pci_dev *dev)
>  	}
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x5a3f, quirk_disable_msi);
>  
>  /* Go through the list of Hypertransport capabilities and
>   * return 1 if a HT MSI capability is found and enabled */

Looks sane.

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw

Patch

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 245d2cd..8c6eb85 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2092,6 +2092,7 @@  static void __devinit quirk_disable_msi(struct pci_dev *dev)
 	}
 }
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_BRIDGE, quirk_disable_msi);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x5a3f, quirk_disable_msi);
 
 /* Go through the list of Hypertransport capabilities and
  * return 1 if a HT MSI capability is found and enabled */