From patchwork Mon Apr 5 16:14:57 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 49394 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 31274B7CF0 for ; Tue, 6 Apr 2010 02:15:16 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755219Ab0DEQPF (ORCPT ); Mon, 5 Apr 2010 12:15:05 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:32839 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755008Ab0DEQPB (ORCPT ); Mon, 5 Apr 2010 12:15:01 -0400 Received: by bwz1 with SMTP id 1so2886944bwz.21 for ; Mon, 05 Apr 2010 09:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=4/JH4sguKZGA/4gI6C1UG71XEYsj3+4peoPNl6fYNd8=; b=W1UqdLjA8izzefVW7qD0UoG986pR8xBN3KpSx42HJ+wTVkASUq9bvQaMOFL/PGX5CF WJrjiqbsbR6bRJRqj1sILpYbIkbpUni8FsStVJCFf/DjTCFmIzggUg301h1OTV8o1t+g MGNdkc1x5cSTfzdiUMEpsR+t9DjudBfu+U8wU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=QuvjastdGcAcScPsO0bI52jRHIjw/p6aXBYhy5XzY9s09Cojc8wOV2vJb4kfWeJuC9 fB4l1YAhlE9AY28OovXyY8oW9nWh0Ln3+LzfIPYt0NnLgF8b3N56ygwdk8BW0wuU7Vw2 QuZuIIbHbh9ab5ckkDxFdT3Ile39/lZYqBcA0= Received: by 10.204.13.68 with SMTP id b4mr7007371bka.133.1270484099662; Mon, 05 Apr 2010 09:14:59 -0700 (PDT) Received: from [127.0.0.1] (gw1.cosmosbay.com [212.99.114.194]) by mx.google.com with ESMTPS id 15sm6009285bwz.4.2010.04.05.09.14.58 (version=SSLv3 cipher=RC4-MD5); Mon, 05 Apr 2010 09:14:59 -0700 (PDT) Subject: Re: [PATCH] sky2: rx hash offload From: Eric Dumazet To: Stephen Hemminger Cc: David Miller , netdev@vger.kernel.org In-Reply-To: <20100405084800.3bcec66a@nehalam> References: <20100405084800.3bcec66a@nehalam> Date: Mon, 05 Apr 2010 18:14:57 +0200 Message-ID: <1270484097.4722.164.camel@edumazet-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le lundi 05 avril 2010 à 08:48 -0700, Stephen Hemminger a écrit : > Marvell Yukon 2 hardware supports hardware receive hash calculation. > Now that Receive Packet Steering is available, add support > to enable it. > > Note: still experimental, tested on only a few variants. > No performance testing has been done. > > Signed-off-by: Stephen Hemminger > > --- > drivers/net/sky2.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++-- > drivers/net/sky2.h | 23 ++++++++++++++++ > 2 files changed, 96 insertions(+), 2 deletions(-) > Cool :) I believe some bits are needed in receive_copy() to transfert rxhash to new skb ? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c index d8ec4c1..f420255 100644 --- a/drivers/net/sky2.c +++ b/drivers/net/sky2.c @@ -2295,6 +2295,8 @@ static struct sk_buff *receive_copy(struct sky2_port *sky2, skb_copy_from_linear_data(re->skb, skb->data, length); skb->ip_summed = re->skb->ip_summed; skb->csum = re->skb->csum; + skb->rxhash = re->skb->rxhash; + re->skb->rxhash = 0; pci_dma_sync_single_for_device(sky2->hw->pdev, re->data_addr, length, PCI_DMA_FROMDEVICE); re->skb->ip_summed = CHECKSUM_NONE;