Patchwork [upstream-fixes] libata: disable NCQ on Crucial C300 SSD

login
register
mail settings
Submitter Tejun Heo
Date April 5, 2010, 1:51 a.m.
Message ID <4BB9421E.9050007@kernel.org>
Download mbox | patch
Permalink /patch/49365/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - April 5, 2010, 1:51 a.m.
Crucial said,

  Thank you for contacting us. We know that with our M225 line of SSDs
  you sometimes need to disable NCQ (native command queuing) to avoid
  just the type of errors you're seeing. Our recommendation for the
  M225 is to add libata.force=noncq to your Linux kernel boot options,
  under the kernel ATA library option.

  I have sent your feedback to the engineers working on the C300, and
  asked them to please pass it on to the firmware team. I have been
  notified that they are in the process of testing and finalizing a
  new firmware version, that you can expect to see released around the
  end of April. We’ll keep you posted as to when it will be available
  for download.

So, turn off NCQ on the drive w/ the current firmware revision.

Reported in the following bug.

  https://bugzilla.kernel.org/show_bug.cgi?id=15573

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: lethalwp@scarlet.be
Reported-by: Luke Macken <lmacken@redhat.com>
---
 drivers/ata/libata-core.c |    3 +++
 1 file changed, 3 insertions(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - April 6, 2010, 2:57 p.m.
On 04/04/2010 09:51 PM, Tejun Heo wrote:
> Crucial said,
>
>    Thank you for contacting us. We know that with our M225 line of SSDs
>    you sometimes need to disable NCQ (native command queuing) to avoid
>    just the type of errors you're seeing. Our recommendation for the
>    M225 is to add libata.force=noncq to your Linux kernel boot options,
>    under the kernel ATA library option.
>
>    I have sent your feedback to the engineers working on the C300, and
>    asked them to please pass it on to the firmware team. I have been
>    notified that they are in the process of testing and finalizing a
>    new firmware version, that you can expect to see released around the
>    end of April. We’ll keep you posted as to when it will be available
>    for download.
>
> So, turn off NCQ on the drive w/ the current firmware revision.
>
> Reported in the following bug.
>
>    https://bugzilla.kernel.org/show_bug.cgi?id=15573
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: lethalwp@scarlet.be
> Reported-by: Luke Macken<lmacken@redhat.com>
> ---
>   drivers/ata/libata-core.c |    3 +++
>   1 file changed, 3 insertions(+)

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 4a28420..c3076d4 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4353,6 +4353,9 @@  static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	{ "HTS541080G9SA00",    "MB4OC60D",     ATA_HORKAGE_NONCQ, },
 	{ "HTS541010G9SA00",    "MBZOC60D",     ATA_HORKAGE_NONCQ, },

+	/* https://bugzilla.kernel.org/show_bug.cgi?id=15573 */
+	{ "C300-CTFDDAC128MAG",	"0001",		ATA_HORKAGE_NONCQ, },
+
 	/* devices which puke on READ_NATIVE_MAX */
 	{ "HDS724040KLSA80",	"KFAOA20N",	ATA_HORKAGE_BROKEN_HPA, },
 	{ "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_HORKAGE_BROKEN_HPA },