diff mbox

[36/36] PCI: Don't set flags to 0 when assign resource fail

Message ID CAE9FiQWiCZB0EvQ2RNujdD1-0pRO_izJrqBwExaK9Md1d5wCjw@mail.gmail.com
State Changes Requested
Headers show

Commit Message

Yinghai Lu July 10, 2015, 5:49 a.m. UTC 
On Thu, Jul 9, 2015 at 7:48 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Thu, Jul 9, 2015 at 7:30 PM, Wei Yang <weiyang@linux.vnet.ibm.com> wrote:
>> If you could update your for-pci-v4.3-next branch, that would be more
>> convenient for me to do the test.
>
> Just updated that branch, please check it.
>

just updated the branch again.

If you don't want to re get it again, please apply attached patch.

Comments

Wei Yang July 11, 2015, 12:03 a.m. UTC | #1 
On Thu, Jul 09, 2015 at 10:49:06PM -0700, Yinghai Lu wrote:
>On Thu, Jul 9, 2015 at 7:48 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>> On Thu, Jul 9, 2015 at 7:30 PM, Wei Yang <weiyang@linux.vnet.ibm.com> wrote:
>>> If you could update your for-pci-v4.3-next branch, that would be more
>>> convenient for me to do the test.
>>
>> Just updated that branch, please check it.
>>
>
>just updated the branch again.
>
>If you don't want to re get it again, please apply attached patch.

Yinghai,

I have tested you latest branch with this one as the last commit:

ec94cc7 PCI: Don't set flags to 0 when assign resource fail

My P8 machine boots up.

Another issue is the SRIOV couldn't be enabled, I am checking the reason. 
This may not related to this patch series.

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yinghai Lu July 11, 2015, 12:42 a.m. UTC | #2 
On Fri, Jul 10, 2015 at 5:03 PM, Wei Yang <weiyang@linux.vnet.ibm.com> wrote:
> On Thu, Jul 09, 2015 at 10:49:06PM -0700, Yinghai Lu wrote:

> I have tested you latest branch with this one as the last commit:
>
> ec94cc7 PCI: Don't set flags to 0 when assign resource fail
>
> My P8 machine boots up.

Good.

>
> Another issue is the SRIOV couldn't be enabled, I am checking the reason.
> This may not related to this patch series.

wonder if could be related to :

https://git.kernel.org/cgit/linux/kernel/git/yinghai/linux-yinghai.git/patch/?id=c642f79dcd6becbb92741816e0b5e81f7664acc7
PCI: Restore pref mmio allocation logic for hostbridge without mmio64

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wei Yang July 11, 2015, 1:37 a.m. UTC | #3 
On Fri, Jul 10, 2015 at 05:42:10PM -0700, Yinghai Lu wrote:
>On Fri, Jul 10, 2015 at 5:03 PM, Wei Yang <weiyang@linux.vnet.ibm.com> wrote:
>> On Thu, Jul 09, 2015 at 10:49:06PM -0700, Yinghai Lu wrote:
>
>> I have tested you latest branch with this one as the last commit:
>>
>> ec94cc7 PCI: Don't set flags to 0 when assign resource fail
>>
>> My P8 machine boots up.
>
>Good.
>
>>
>> Another issue is the SRIOV couldn't be enabled, I am checking the reason.
>> This may not related to this patch series.
>
>wonder if could be related to :
>
>https://git.kernel.org/cgit/linux/kernel/git/yinghai/linux-yinghai.git/patch/?id=c642f79dcd6becbb92741816e0b5e81f7664acc7
>PCI: Restore pref mmio allocation logic for hostbridge without mmio64
>

Looks no.

I have tried to revert all your patches, still not work. Need to get more time
to investigate.

>Yinghai
diff mbox

Patch

---
 drivers/pci/bus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/pci/bus.c
===================================================================
--- linux-2.6.orig/drivers/pci/bus.c
+++ linux-2.6/drivers/pci/bus.c
@@ -140,7 +140,7 @@  static int pci_bus_alloc_from_region(str
 	type_mask |= IORESOURCE_TYPE_BITS;
 
 	pci_bus_for_each_resource(bus, r, i) {
-		if (!r)
+		if (!r || resource_disabled(r))
 			continue;
 
 		/* type_mask must match */