| Message ID | 1436444786-4127-3-git-send-email-michal.kazior@tieto.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, Jul 09, 2015 at 02:26:25PM +0200, Michal Kazior wrote: > Station entry should be removed from driver to > avoid unprivilaged traffic. It's also worth it to > Deauth. The hostapd_drv_sta_remove() part is not applicable without patch 1/3 and it should really be merged into that patch.. As far as the ap_sta_disconnect() call is concerned, that might be reasonable addition even without 1/3 (which I'm not applying in its current state). Though, the reason code should likely be something else than WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY.
diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c index 957fd02eff24..cf3567fd3031 100644 --- a/src/ap/ieee802_11.c +++ b/src/ap/ieee802_11.c @@ -2426,6 +2426,9 @@ static void handle_assoc_cb(struct hostapd_data *hapd, hostapd_logger(hapd, mgmt->da, HOSTAPD_MODULE_IEEE80211, HOSTAPD_LEVEL_DEBUG, "did not acknowledge association response"); + hostapd_drv_sta_remove(hapd, sta->addr); + ap_sta_disconnect(hapd, sta, sta->addr, + WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY); sta->flags &= ~WLAN_STA_ASSOC_REQ_OK; return; }
Station entry should be removed from driver to avoid unprivilaged traffic. It's also worth it to Deauth. Signed-off-by: Michal Kazior <michal.kazior@tieto.com> --- src/ap/ieee802_11.c | 3 +++ 1 file changed, 3 insertions(+)