From patchwork Fri Apr 2 09:11:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshiaki Tamura X-Patchwork-Id: 49286 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5EE21B6EFF for ; Fri, 2 Apr 2010 20:18:46 +1100 (EST) Received: from localhost ([127.0.0.1]:58757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxcyD-0006L9-W3 for incoming@patchwork.ozlabs.org; Fri, 02 Apr 2010 05:15:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxcwB-0005tP-NG for qemu-devel@nongnu.org; Fri, 02 Apr 2010 05:13:11 -0400 Received: from [140.186.70.92] (port=54077 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxcwA-0005sO-5x for qemu-devel@nongnu.org; Fri, 02 Apr 2010 05:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nxcw8-00034v-A1 for qemu-devel@nongnu.org; Fri, 02 Apr 2010 05:13:10 -0400 Received: from sh.osrg.net ([192.16.179.4]:40087) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nxcw7-000345-Pk for qemu-devel@nongnu.org; Fri, 02 Apr 2010 05:13:08 -0400 Received: from fs.osrg.net (postfix@fs.osrg.net [10.0.0.12]) by sh.osrg.net (8.14.3/8.14.3/OSRG-NET) with ESMTP id o329Cucn030049; Fri, 2 Apr 2010 18:12:57 +0900 Received: from localhost (hype-wd0.osrg.net [10.72.1.16]) by fs.osrg.net (Postfix) with ESMTP id A09EC3E01FC; Fri, 2 Apr 2010 18:12:56 +0900 (JST) From: Yoshiaki Tamura To: qemu-devel@nongnu.org Date: Fri, 2 Apr 2010 18:11:11 +0900 Message-Id: <1270199471-25630-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> X-Mailer: git-send-email 1.7.0.31.g1df487 X-Dispatcher: imput version 20070423(IM149) Lines: 46 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Fri, 02 Apr 2010 18:12:57 +0900 (JST) X-Virus-Scanned: clamav-milter 0.95.3 at sh X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: Yoshiaki Tamura Subject: [Qemu-devel] [PATCH] vnc: don't forget to call check_pointer_type_change in pointer_event() and set_encodings(). X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The following commit broke the behavior of vnc mouse. Forgetting to call check_pointer_type_change in pointer_event() and set_encodings() seems to be the reason. This patch fix this issue. commit 37c34d9d5d87ea9d51760310c8863b82cb8c055a Author: Anthony Liguori Date: Wed Mar 10 09:38:29 2010 -0600 input: make vnc use mouse mode notifiers When we switch to absolute mode, we send out a notification (if the client supports it). Today, we only send this notification when the client sends u a mouse event and we're in the wrong mode. Signed-off-by: Anthony Liguori --- vnc.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/vnc.c b/vnc.c index e678fcc..cb4a453 100644 --- a/vnc.c +++ b/vnc.c @@ -1480,6 +1480,8 @@ static void pointer_event(VncState *vs, int button_mask, int x, int y) vs->last_x = x; vs->last_y = y; } + + check_pointer_type_change(&vs->mouse_mode_notifier); } static void reset_keys(VncState *vs) @@ -1820,6 +1822,8 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings) break; } } + + check_pointer_type_change(&vs->mouse_mode_notifier); } static void set_pixel_conversion(VncState *vs)