diff mbox

[1/3] lib: fwts_framework: Append "tests" to --uefi and --acpi

Message ID 1436259121-23025-2-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung July 7, 2015, 8:51 a.m. UTC
This is to solve confusion for uefi for UEFI table tests
and --uefitests for all uefi tests

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/lib/src/fwts_framework.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Colin Ian King July 7, 2015, 8:54 a.m. UTC | #1
On 07/07/15 09:51, Alex Hung wrote:
> This is to solve confusion for uefi for UEFI table tests
> and --uefitests for all uefi tests
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/lib/src/fwts_framework.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 2753d54..92431a9 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -102,11 +102,11 @@ static fwts_option fwts_framework_options[] = {
>  	{ "filter-error-keep",	"",   1, "Keep errors that match any of the specified labels." },
>  	{ "acpica-debug",	"",   0, "Enable ACPICA debug/warning messages." },
>  	{ "acpica",		"",   1, "Enable ACPICA run time options." },
> -	{ "uefi",		"",   0, "Run UEFI tests." },
> +	{ "uefitests",		"",   0, "Run UEFI tests." },
>  	{ "rsdp",		"R:", 1, "Specify the physical address of the ACPI RSDP." },
>  	{ "pm-method",  "",   1, "Select the power method to use. Accepted values are \"logind\", \"pm-utils\", \"sysfs\""},
>  	{ "show-tests-categories","", 0, "Show tests and associated categories." },
> -	{ "acpi",		"",   0, "Run ACPI tests." },
> +	{ "acpitests",		"",   0, "Run ACPI tests." },
>  	{ NULL, NULL, 0, NULL }
>  };
>  
> @@ -1216,7 +1216,7 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>  			if (fwts_framework_acpica_parse(fw, optarg) != FWTS_OK)
>  				return FWTS_ERROR;
>  			break;
> -		case 36: /* --uefi */
> +		case 36: /* --uefitests */
>  			fw->flags |= FWTS_FLAG_TEST_UEFI;
>  			break;
>  		case 37: /* --rsdp */
> @@ -1229,7 +1229,7 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>  		case 39: /* --show-tests-categories */
>  			fw->flags |= FWTS_FLAG_SHOW_TESTS_CATEGORIES;
>  			break;
> -		case 40: /* --acpi */
> +		case 40: /* --acpitests */
>  			fw->flags |= FWTS_FLAG_TEST_ACPI;
>  			break;
>  		}
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu July 8, 2015, 2:08 a.m. UTC | #2
On 2015年07月07日 16:51, Alex Hung wrote:
> This is to solve confusion for uefi for UEFI table tests
> and --uefitests for all uefi tests
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/lib/src/fwts_framework.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 2753d54..92431a9 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -102,11 +102,11 @@ static fwts_option fwts_framework_options[] = {
>   	{ "filter-error-keep",	"",   1, "Keep errors that match any of the specified labels." },
>   	{ "acpica-debug",	"",   0, "Enable ACPICA debug/warning messages." },
>   	{ "acpica",		"",   1, "Enable ACPICA run time options." },
> -	{ "uefi",		"",   0, "Run UEFI tests." },
> +	{ "uefitests",		"",   0, "Run UEFI tests." },
>   	{ "rsdp",		"R:", 1, "Specify the physical address of the ACPI RSDP." },
>   	{ "pm-method",  "",   1, "Select the power method to use. Accepted values are \"logind\", \"pm-utils\", \"sysfs\""},
>   	{ "show-tests-categories","", 0, "Show tests and associated categories." },
> -	{ "acpi",		"",   0, "Run ACPI tests." },
> +	{ "acpitests",		"",   0, "Run ACPI tests." },
>   	{ NULL, NULL, 0, NULL }
>   };
>   
> @@ -1216,7 +1216,7 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>   			if (fwts_framework_acpica_parse(fw, optarg) != FWTS_OK)
>   				return FWTS_ERROR;
>   			break;
> -		case 36: /* --uefi */
> +		case 36: /* --uefitests */
>   			fw->flags |= FWTS_FLAG_TEST_UEFI;
>   			break;
>   		case 37: /* --rsdp */
> @@ -1229,7 +1229,7 @@ int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
>   		case 39: /* --show-tests-categories */
>   			fw->flags |= FWTS_FLAG_SHOW_TESTS_CATEGORIES;
>   			break;
> -		case 40: /* --acpi */
> +		case 40: /* --acpitests */
>   			fw->flags |= FWTS_FLAG_TEST_ACPI;
>   			break;
>   		}
Acked-by: Ivan Hu<ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
index 2753d54..92431a9 100644
--- a/src/lib/src/fwts_framework.c
+++ b/src/lib/src/fwts_framework.c
@@ -102,11 +102,11 @@  static fwts_option fwts_framework_options[] = {
 	{ "filter-error-keep",	"",   1, "Keep errors that match any of the specified labels." },
 	{ "acpica-debug",	"",   0, "Enable ACPICA debug/warning messages." },
 	{ "acpica",		"",   1, "Enable ACPICA run time options." },
-	{ "uefi",		"",   0, "Run UEFI tests." },
+	{ "uefitests",		"",   0, "Run UEFI tests." },
 	{ "rsdp",		"R:", 1, "Specify the physical address of the ACPI RSDP." },
 	{ "pm-method",  "",   1, "Select the power method to use. Accepted values are \"logind\", \"pm-utils\", \"sysfs\""},
 	{ "show-tests-categories","", 0, "Show tests and associated categories." },
-	{ "acpi",		"",   0, "Run ACPI tests." },
+	{ "acpitests",		"",   0, "Run ACPI tests." },
 	{ NULL, NULL, 0, NULL }
 };
 
@@ -1216,7 +1216,7 @@  int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
 			if (fwts_framework_acpica_parse(fw, optarg) != FWTS_OK)
 				return FWTS_ERROR;
 			break;
-		case 36: /* --uefi */
+		case 36: /* --uefitests */
 			fw->flags |= FWTS_FLAG_TEST_UEFI;
 			break;
 		case 37: /* --rsdp */
@@ -1229,7 +1229,7 @@  int fwts_framework_options_handler(fwts_framework *fw, int argc, char * const ar
 		case 39: /* --show-tests-categories */
 			fw->flags |= FWTS_FLAG_SHOW_TESTS_CATEGORIES;
 			break;
-		case 40: /* --acpi */
+		case 40: /* --acpitests */
 			fw->flags |= FWTS_FLAG_TEST_ACPI;
 			break;
 		}