Patchwork [2/2] netdev/fec.c: fix timeout warning message

login
register
mail settings
Submitter Bryan Wu
Date April 1, 2010, 10:56 a.m.
Message ID <1270119366-6301-3-git-send-email-bryan.wu@canonical.com>
Download mbox | patch
Permalink /patch/49204/
State Superseded
Delegated to: Andy Whitcroft
Headers show

Comments

Bryan Wu - April 1, 2010, 10:56 a.m.
BugLink: http://bugs.launchpad.net/bugs/546649
BugLink: http://bugs.launchpad.net/bugs/457878

We will get lots of timeout error message when transfer large file. It is
not an error, just a warning and it is not an impact to performance.

So set the printk message level as warning not an error.

Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 drivers/net/fec.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 53240d3..92a67a1 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
@@ -644,7 +644,7 @@  static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)
 		cpu_relax();
 		if (timeout-- < 0) {
 			fep->mii_timeout = 1;
-			printk(KERN_ERR "FEC: MDIO read timeout\n");
+			printk(KERN_WARNING "FEC: MDIO read timeout\n");
 			return -ETIMEDOUT;
 		}
 	}
@@ -675,7 +675,7 @@  static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum,
 		cpu_relax();
 		if (timeout-- < 0) {
 			fep->mii_timeout = 1;
-			printk(KERN_ERR "FEC: MDIO write timeout\n");
+			printk(KERN_WARNING "FEC: MDIO write timeout\n");
 			return -ETIMEDOUT;
 		}
 	}