[PULL,gpio-for-next] gpio: make flags mandatory for gpiod_get functions
mbox

Message ID 20150706090759.GS11824@pengutronix.de
State New
Headers show

Pull-request

git://git.pengutronix.de/git/ukl/linux.git tags/gpiod-flags-for-4.3

Message

Uwe Kleine-König July 6, 2015, 9:07 a.m. UTC
Hello,

now that all patches that were in next hit Linus Torvalds' tree and
v4.2-rc1 is out here comes the promised pull request that makes usage of
the flags parameter mandatory for gpiod_get et al:

The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:

  Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)

are available in the git repository at:

  git://git.pengutronix.de/git/ukl/linux.git tags/gpiod-flags-for-4.3

for you to fetch changes up to b17d1bf16cc72a374a48d748940f700009d40ff4:

  gpio: make flags mandatory for gpiod_get functions (2015-07-06 10:39:24 +0200)

----------------------------------------------------------------
The last patch in this series makes the flags parameter for the various
gpiod_get* functions mandatory and so allows to remove an ugly cpp hack
introduced in commit 39b2bbe3d715 (gpio: add flags argument to gpiod_get*()
functions) for v3.17-rc1.

The other nine commits fix the last remaining users of these functions that
don't pass flags yet. (Only etraxfs-uart wasn't fixed; this driver's use of the
gpiod functions needs fixing anyhow.)

----------------------------------------------------------------

According to the coccinelle-script I wrote all users (apart from
etraxfs-uart) are fixed now.

As some of the maintainers requested it, I'll resend the patches
contained in this series as a reply to this mail.

It would be great if this could be put into next via the gpio tree to
give new users enough time to adapt their patches.

Thanks
Uwe

Uwe Kleine-König (10):
      drm/msm/dp: use flags argument of devm_gpiod_get to set direction
      drm/tilcdc: panel: make better use of gpiod API
      iio: light: stk3310: use flags argument of devm_gpiod_get
      iio: magn: bmc150: use flags argument of devm_gpiod_get
      media: i2c/adp1653: set enable gpio to output
      NFC: nxp-nci_i2c: use flags argument of devm_gpiod_get_index
      phy: tusb1210: make better use of gpiod API
      usb: dwc3: pci: make better use of gpiod API
      usb: pass flags parameter to gpiod_get functions
      gpio: make flags mandatory for gpiod_get functions

 drivers/gpio/devres.c                  | 18 ++++----
 drivers/gpio/gpiolib.c                 | 16 +++----
 drivers/gpu/drm/msm/edp/edp_ctrl.c     | 17 +------
 drivers/gpu/drm/tilcdc/tilcdc_panel.c  | 22 +++------
 drivers/iio/light/stk3310.c            |  6 +--
 drivers/iio/magnetometer/bmc150_magn.c |  6 +--
 drivers/media/i2c/adp1653.c            |  2 +-
 drivers/nfc/nxp-nci/i2c.c              | 10 ++---
 drivers/phy/phy-tusb1210.c             | 30 +++++--------
 drivers/usb/dwc3/dwc3-pci.c            | 26 ++++++-----
 drivers/usb/gadget/udc/pxa27x_udc.c    |  2 +-
 drivers/usb/phy/phy-generic.c          |  6 ++-
 include/linux/gpio/consumer.h          | 82 ++++++++++------------------------
 13 files changed, 88 insertions(+), 155 deletions(-)

Comments

Uwe Kleine-König July 8, 2015, 10:51 a.m. UTC | #1
Hello Linus, hello Alexandre,

On Mon, Jul 06, 2015 at 11:07:59AM +0200, Uwe Kleine-König wrote:
> now that all patches that were in next hit Linus Torvalds' tree and
> v4.2-rc1 is out here comes the promised pull request that makes usage of
> the flags parameter mandatory for gpiod_get et al:
> 
> The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:
> 
>   Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)
> 
> are available in the git repository at:
> 
>   git://git.pengutronix.de/git/ukl/linux.git tags/gpiod-flags-for-4.3
> 
> for you to fetch changes up to b17d1bf16cc72a374a48d748940f700009d40ff4:
> 
>   gpio: make flags mandatory for gpiod_get functions (2015-07-06 10:39:24 +0200)
gentle ping!

Best regards
Uwe
Uwe Kleine-König July 15, 2015, 6:28 a.m. UTC | #2
Hello Linus, hello Alexandre,

On Wed, Jul 08, 2015 at 12:51:38PM +0200, Uwe Kleine-König wrote:
> On Mon, Jul 06, 2015 at 11:07:59AM +0200, Uwe Kleine-König wrote:
> > now that all patches that were in next hit Linus Torvalds' tree and
> > v4.2-rc1 is out here comes the promised pull request that makes usage of
> > the flags parameter mandatory for gpiod_get et al:
> > 
> > The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:
> > 
> >   Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)
> > 
> > are available in the git repository at:
> > 
> >   git://git.pengutronix.de/git/ukl/linux.git tags/gpiod-flags-for-4.3
> > 
> > for you to fetch changes up to b17d1bf16cc72a374a48d748940f700009d40ff4:
> > 
> >   gpio: make flags mandatory for gpiod_get functions (2015-07-06 10:39:24 +0200)
> gentle ping!
the (or at least my) plan was to get this into next early after the
merge window for 4.2 closes. Now we're already at -rc2. Can you please
comment?

As of next-20150715 there don't seem to be any new users of gpiod
without flags btw.

Best regards
Uwe
Alexandre Courbot July 15, 2015, 6:39 a.m. UTC | #3
On Wed, Jul 15, 2015 at 3:28 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello Linus, hello Alexandre,
>
> On Wed, Jul 08, 2015 at 12:51:38PM +0200, Uwe Kleine-König wrote:
>> On Mon, Jul 06, 2015 at 11:07:59AM +0200, Uwe Kleine-König wrote:
>> > now that all patches that were in next hit Linus Torvalds' tree and
>> > v4.2-rc1 is out here comes the promised pull request that makes usage of
>> > the flags parameter mandatory for gpiod_get et al:
>> >
>> > The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:
>> >
>> >   Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.pengutronix.de/git/ukl/linux.git tags/gpiod-flags-for-4.3
>> >
>> > for you to fetch changes up to b17d1bf16cc72a374a48d748940f700009d40ff4:
>> >
>> >   gpio: make flags mandatory for gpiod_get functions (2015-07-06 10:39:24 +0200)
>> gentle ping!
> the (or at least my) plan was to get this into next early after the
> merge window for 4.2 closes. Now we're already at -rc2. Can you please
> comment?
>
> As of next-20150715 there don't seem to be any new users of gpiod
> without flags btw.

I'm all for taking this into -next ASAP then. Linus has control over
the tree though, so his action is required.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij July 17, 2015, 12:28 p.m. UTC | #4
On Wed, Jul 15, 2015 at 8:39 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
> On Wed, Jul 15, 2015 at 3:28 PM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>> Hello Linus, hello Alexandre,
>>
>> On Wed, Jul 08, 2015 at 12:51:38PM +0200, Uwe Kleine-König wrote:
>>> On Mon, Jul 06, 2015 at 11:07:59AM +0200, Uwe Kleine-König wrote:
>>> > now that all patches that were in next hit Linus Torvalds' tree and
>>> > v4.2-rc1 is out here comes the promised pull request that makes usage of
>>> > the flags parameter mandatory for gpiod_get et al:
>>> >
>>> > The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754:
>>> >
>>> >   Linux 4.2-rc1 (2015-07-05 11:01:52 -0700)
>>> >
>>> > are available in the git repository at:
>>> >
>>> >   git://git.pengutronix.de/git/ukl/linux.git tags/gpiod-flags-for-4.3
>>> >
>>> > for you to fetch changes up to b17d1bf16cc72a374a48d748940f700009d40ff4:
>>> >
>>> >   gpio: make flags mandatory for gpiod_get functions (2015-07-06 10:39:24 +0200)
>>> gentle ping!
>> the (or at least my) plan was to get this into next early after the
>> merge window for 4.2 closes. Now we're already at -rc2. Can you please
>> comment?
>>
>> As of next-20150715 there don't seem to be any new users of gpiod
>> without flags btw.
>
> I'm all for taking this into -next ASAP then. Linus has control over
> the tree though, so his action is required.

I am pushing it today.

I finally found this message in my messy inbox. I'm a bit up over my
ears in patches...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Uwe Kleine-König July 20, 2015, 6:56 a.m. UTC | #5
Hello Linus,

On Fri, Jul 17, 2015 at 02:28:25PM +0200, Linus Walleij wrote:
> On Wed, Jul 15, 2015 at 8:39 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
> > I'm all for taking this into -next ASAP then. Linus has control over
> > the tree though, so his action is required.
> 
> I am pushing it today.
> 
> I finally found this message in my messy inbox. I'm a bit up over my
> ears in patches...
This somehow failed.  My tag is merged in your devel branch, but this
contains several commits missing in your for-next. Is this intended?

Best regards
Uwe
Linus Walleij July 20, 2015, 7:41 a.m. UTC | #6
On Mon, Jul 20, 2015 at 8:56 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Hello Linus,
>
> On Fri, Jul 17, 2015 at 02:28:25PM +0200, Linus Walleij wrote:
>> On Wed, Jul 15, 2015 at 8:39 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
>> > I'm all for taking this into -next ASAP then. Linus has control over
>> > the tree though, so his action is required.
>>
>> I am pushing it today.
>>
>> I finally found this message in my messy inbox. I'm a bit up over my
>> ears in patches...
> This somehow failed.  My tag is merged in your devel branch, but this
> contains several commits missing in your for-next. Is this intended?

No ... :(

I just pulled it in. If anything is to blame, I hope it's not me, I just
issued git pull.

commit 2563606ce45314bfeae811edfa9984b1921fff06
Merge: 015403145a65 b17d1bf16cc7
Author: Linus Walleij <linus.walleij@linaro.org>
Date:   Fri Jul 17 13:44:15 2015 +0200

    Merge tag 'gpiod-flags-for-4.3' of
git://git.pengutronix.de/git/ukl/linux into devel

    The last patch in this series makes the flags parameter for the various
    gpiod_get* functions mandatory and so allows to remove an ugly cpp hack
    introduced in commit 39b2bbe3d715 (gpio: add flags argument to gpiod_get*()
    functions) for v3.17-rc1.

    The other nine commits fix the last remaining users of these functions that
    don't pass flags yet. (Only etraxfs-uart wasn't fixed; this
driver's use of the
    gpiod functions needs fixing anyhow.)


Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Uwe Kleine-König July 20, 2015, 7:51 a.m. UTC | #7
Hello Linus,

On Mon, Jul 20, 2015 at 09:41:09AM +0200, Linus Walleij wrote:
> On Mon, Jul 20, 2015 at 8:56 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > Hello Linus,
> >
> > On Fri, Jul 17, 2015 at 02:28:25PM +0200, Linus Walleij wrote:
> >> On Wed, Jul 15, 2015 at 8:39 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
> >> > I'm all for taking this into -next ASAP then. Linus has control over
> >> > the tree though, so his action is required.
> >>
> >> I am pushing it today.
> >>
> >> I finally found this message in my messy inbox. I'm a bit up over my
> >> ears in patches...
> > This somehow failed.  My tag is merged in your devel branch, but this
> > contains several commits missing in your for-next. Is this intended?
> 
> No ... :(
> 
> I just pulled it in. If anything is to blame, I hope it's not me, I just
> issued git pull.
> 
> commit 2563606ce45314bfeae811edfa9984b1921fff06
> Merge: 015403145a65 b17d1bf16cc7
> Author: Linus Walleij <linus.walleij@linaro.org>
> Date:   Fri Jul 17 13:44:15 2015 +0200
> 
>     Merge tag 'gpiod-flags-for-4.3' of
> git://git.pengutronix.de/git/ukl/linux into devel
> 
>     The last patch in this series makes the flags parameter for the various
>     gpiod_get* functions mandatory and so allows to remove an ugly cpp hack
>     introduced in commit 39b2bbe3d715 (gpio: add flags argument to gpiod_get*()
>     functions) for v3.17-rc1.
> 
>     The other nine commits fix the last remaining users of these functions that
>     don't pass flags yet. (Only etraxfs-uart wasn't fixed; this
> driver's use of the
>     gpiod functions needs fixing anyhow.)
this is fine. It contains my signed data (you have to do

	git cat-file commit 2563606ce45314bfeae811edfa9984b1921fff06

to see that) and the usual ö-Problem doesn't exist here, because it was
me who created the commits.

Best regards
Uwe
Linus Walleij July 20, 2015, 8:28 a.m. UTC | #8
On Mon, Jul 20, 2015 at 8:56 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

>> I finally found this message in my messy inbox. I'm a bit up over my
>> ears in patches...
>
> This somehow failed.  My tag is merged in your devel branch, but this
> contains several commits missing in your for-next. Is this intended?

Ah wait I see.

I pushed it to devel for testing, but the 0day build was not completing
so I did not get green light to push it to next.

I'll push to linux-next now.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html