From patchwork Wed Mar 31 07:33:58 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 49116 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 43122B7C7E for ; Wed, 31 Mar 2010 21:03:15 +1100 (EST) Received: from localhost ([127.0.0.1]:50078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwulT-0005Am-Nf for incoming@patchwork.ozlabs.org; Wed, 31 Mar 2010 06:03:11 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwudQ-0006Z2-LZ for qemu-devel@nongnu.org; Wed, 31 Mar 2010 05:54:53 -0400 Received: from [140.186.70.92] (port=33653 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwudN-0006TL-U3 for qemu-devel@nongnu.org; Wed, 31 Mar 2010 05:54:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwsT8-0007BI-Mg for qemu-devel@nongnu.org; Wed, 31 Mar 2010 03:36:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47279) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwsT4-0007AS-PW for qemu-devel@nongnu.org; Wed, 31 Mar 2010 03:36:05 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2V7a1H1010129 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Mar 2010 03:36:01 -0400 Received: from localhost (vpn-235-197.phx2.redhat.com [10.3.235.197]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2V7ZxQh009962; Wed, 31 Mar 2010 03:36:00 -0400 From: Amit Shah To: qemu list Date: Wed, 31 Mar 2010 13:03:58 +0530 Message-Id: <1270020848-15526-8-git-send-email-amit.shah@redhat.com> In-Reply-To: <1270020848-15526-7-git-send-email-amit.shah@redhat.com> References: <1270020848-15526-1-git-send-email-amit.shah@redhat.com> <1270020848-15526-2-git-send-email-amit.shah@redhat.com> <1270020848-15526-3-git-send-email-amit.shah@redhat.com> <1270020848-15526-4-git-send-email-amit.shah@redhat.com> <1270020848-15526-5-git-send-email-amit.shah@redhat.com> <1270020848-15526-6-git-send-email-amit.shah@redhat.com> <1270020848-15526-7-git-send-email-amit.shah@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Amit Shah , "Michael S. Tsirkin" , Gerd Hoffmann , Juan Quintela Subject: [Qemu-devel] [PATCH 07/17] virtio-serial: Remove redundant check for 0-sized write request X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The check for a 0-sized write request to a guest port is not necessary; the while loop below won't be executed in this case and all will be fine. Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 80f0259..4435c62 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -91,9 +91,6 @@ static size_t write_to_port(VirtIOSerialPort *port, if (!virtio_queue_ready(vq)) { return 0; } - if (!size) { - return 0; - } while (offset < size) { int i;