| Message ID | 1435933551-28696-3-git-send-email-maxime.ripard@free-electrons.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Maxime Ripard <maxime.ripard@free-electrons.com> Date: Fri, 3 Jul 2015 16:25:47 +0200 > The documentation of request_percpu_irq is confusing and suggest that the > interrupt is not enabled at all, while it is actually enabled on the local > CPU. > > Clarify that. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> You should submit this separately to the IRQ layer maintainers, rather than try to include it in an unrelated set of changes targetting net-next. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index e68932bb308e..ec31697f29b3 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1757,9 +1757,10 @@ int setup_percpu_irq(unsigned int irq, struct irqaction *act) * @devname: An ascii name for the claiming device * @dev_id: A percpu cookie passed back to the handler function * - * This call allocates interrupt resources, but doesn't - * automatically enable the interrupt. It has to be done on each - * CPU using enable_percpu_irq(). + * This call allocates interrupt resources and enables the + * interrupt on the local CPU. If the interrupt is supposed to be + * enabled on other CPUs, it has to be done on each CPU using + * enable_percpu_irq(). * * Dev_id must be globally unique. It is a per-cpu variable, and * the handler gets called with the interrupted CPU's instance of
The documentation of request_percpu_irq is confusing and suggest that the interrupt is not enabled at all, while it is actually enabled on the local CPU. Clarify that. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- kernel/irq/manage.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)