diff mbox

Fix PR52482, libitm compilation in OSX ppc with old cctools

Message ID m2mvzd8p9z.fsf@gmail.com
State New
Headers show

Commit Message

Carlos Sánchez de La Lama July 3, 2015, 11:16 a.m. UTC
Hi all,

PR52482 seems to be cause by old gas not supporting named parameters in
macros. Xcode-2.5 (last available for OSX PPC) gas version is 1.38.

Patch is against gcc-4.8.4, but affected lines have not changed in SVN HEAD.

BR

Carlos

Comments

Mike Stump July 3, 2015, 5:57 p.m. UTC | #1
On Jul 3, 2015, at 4:16 AM, Carlos Sánchez de La Lama <csanchezdll@gmail.com> wrote:
> PR52482 seems to be cause by old gas not supporting named parameters in
> macros. Xcode-2.5 (last available for OSX PPC) gas version is 1.38.
> 
> Patch is against gcc-4.8.4, but affected lines have not changed in SVN HEAD.

Ok.

I dropped this into all active release branches as well.

If anyone spots any problems with the change, let me know.

If you do a test suite run, feel free to email it to the test results list.
Carlos Sánchez de La Lama July 6, 2015, 7:16 a.m. UTC | #2
>> Patch is against gcc-4.8.4, but affected lines have not changed in SVN HEAD.
>
> I dropped this into all active release branches as well.

Ok, thanks :)

> If you do a test suite run, feel free to email it to the test results
> list.

I am running "make check" on my (locally patched) 4.8.4. Will compile
and run testuite an active branch afterwards (everything takes a while
on my old G4).

BR

Carlos
diff mbox

Patch

diff -ur gcc-4.8.4.old/libitm/config/powerpc/sjlj.S gcc-4.8.4/libitm/config/powerpc/sjlj.S
--- gcc-4.8.4.old/libitm/config/powerpc/sjlj.S	2014-04-04 16:17:55.000000000 +0200
+++ gcc-4.8.4/libitm/config/powerpc/sjlj.S	2015-07-03 11:34:23.000000000 +0200
@@ -83,16 +83,16 @@ 
 	bl	\name
 .endm
 #elif defined(_CALL_DARWIN)
-.macro FUNC name
+.macro FUNC
 	.globl	_$0
 _$0:
 .endmacro
-.macro END name
+.macro END
 .endmacro
-.macro HIDDEN name
+.macro HIDDEN
 	.private_extern _$0
 .endmacro
-.macro CALL name
+.macro CALL
 	bl	_$0
 .endmacro
 # ifdef __ppc64__