Patchwork [#upstream-fixes] libata-sff: don't whine on spurious IRQ

login
register
mail settings
Submitter Tejun Heo
Date March 31, 2010, 7:41 a.m.
Message ID <4BB2FC9E.3050301@kernel.org>
Download mbox | patch
Permalink /patch/49086/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Tejun Heo - March 31, 2010, 7:41 a.m.
On configurations where IRQ line is shared with a different
controller, spurious IRQs may happen continuously.  The message was
put there primarily for debugging anyway.  Kill it.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 drivers/ata/libata-sff.c |    4 ----
 1 file changed, 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - April 6, 2010, 2:57 p.m.
On 03/31/2010 03:41 AM, Tejun Heo wrote:
> On configurations where IRQ line is shared with a different
> controller, spurious IRQs may happen continuously.  The message was
> put there primarily for debugging anyway.  Kill it.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> ---
>   drivers/ata/libata-sff.c |    4 ----
>   1 file changed, 4 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 2774772..9d20f7a 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1815,10 +1815,6 @@  retry:
 			    !ap->ops->sff_irq_check(ap))
 				continue;

-			if (printk_ratelimit())
-				ata_port_printk(ap, KERN_INFO,
-						"clearing spurious IRQ\n");
-
 			if (idle & (1 << i)) {
 				ap->ops->sff_check_status(ap);
 				ap->ops->sff_irq_clear(ap);