| Message ID | 1435882592-487-8-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hello Simon, Am 03.07.2015 um 02:15 schrieb Simon Glass: > When driver model is not used the current code does not correctly select > the pinmux for the I2C bus. This bug was introduced by this commit: > > 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/i2c/s3c24x0_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Heiko Schocher <hs@denx.de> As it is a bugfix, this should go in the current release ... right? bye, Heiko > > diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c > index c053e84..9a04e48 100644 > --- a/drivers/i2c/s3c24x0_i2c.c > +++ b/drivers/i2c/s3c24x0_i2c.c > @@ -1035,7 +1035,7 @@ static void process_nodes(const void *blob, int node_list[], int count, > CONFIG_SYS_I2C_S3C24X0_SPEED); > bus->node = node; > bus->bus_num = i; > - exynos_pinmux_config(PERIPH_ID_I2C0 + bus->id, flags); > + exynos_pinmux_config(bus->id, flags); > > /* Mark position as used */ > node_list[i] = -1; >
Hi Minkyu, Przemyslaw, On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: > Hello Simon, > > Am 03.07.2015 um 02:15 schrieb Simon Glass: >> >> When driver model is not used the current code does not correctly select >> the pinmux for the I2C bus. This bug was introduced by this commit: >> >> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >> >> Signed-off-by: Simon Glass <sjg@chromium.org> >> --- >> >> drivers/i2c/s3c24x0_i2c.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > Acked-by: Heiko Schocher <hs@denx.de> > > As it is a bugfix, this should go in the current release ... right? Minkyu, are you able to pick this up please? If not I can do it. Przemyslaw can you please review this fix? Regards, Simon > > bye, > Heiko >> >> >> diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c >> index c053e84..9a04e48 100644 >> --- a/drivers/i2c/s3c24x0_i2c.c >> +++ b/drivers/i2c/s3c24x0_i2c.c >> @@ -1035,7 +1035,7 @@ static void process_nodes(const void *blob, int >> node_list[], int count, >> >> CONFIG_SYS_I2C_S3C24X0_SPEED); >> bus->node = node; >> bus->bus_num = i; >> - exynos_pinmux_config(PERIPH_ID_I2C0 + bus->id, flags); >> + exynos_pinmux_config(bus->id, flags); >> >> /* Mark position as used */ >> node_list[i] = -1; >> > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Dear Simon, On 07/07/15 00:27, Simon Glass wrote: > Hi Minkyu, Przemyslaw, > > On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: >> Hello Simon, >> >> Am 03.07.2015 um 02:15 schrieb Simon Glass: >>> >>> When driver model is not used the current code does not correctly select >>> the pinmux for the I2C bus. This bug was introduced by this commit: >>> >>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >>> >>> Signed-off-by: Simon Glass <sjg@chromium.org> >>> --- >>> >>> drivers/i2c/s3c24x0_i2c.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> Acked-by: Heiko Schocher <hs@denx.de> >> >> As it is a bugfix, this should go in the current release ... right? > > Minkyu, are you able to pick this up please? If not I can do it. > Only this patch? or all of samsung related patches? Thanks, Minkyu Kang.
Hello Simon, On 07/03/2015 02:15 AM, Simon Glass wrote: > When driver model is not used the current code does not correctly select > the pinmux for the I2C bus. This bug was introduced by this commit: > > 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api Ah that's right, thanks for fixing! > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/i2c/s3c24x0_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c > index c053e84..9a04e48 100644 > --- a/drivers/i2c/s3c24x0_i2c.c > +++ b/drivers/i2c/s3c24x0_i2c.c > @@ -1035,7 +1035,7 @@ static void process_nodes(const void *blob, int node_list[], int count, > CONFIG_SYS_I2C_S3C24X0_SPEED); > bus->node = node; > bus->bus_num = i; > - exynos_pinmux_config(PERIPH_ID_I2C0 + bus->id, flags); > + exynos_pinmux_config(bus->id, flags); > > /* Mark position as used */ > node_list[i] = -1; > Reviewed-by: Przemyslaw Marczak <p.marczak@samsung.com> Best regards,
Hi Minkyu, On 6 July 2015 at 19:36, Minkyu Kang <mk7.kang@samsung.com> wrote: > Dear Simon, > > On 07/07/15 00:27, Simon Glass wrote: >> Hi Minkyu, Przemyslaw, >> >> On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: >>> Hello Simon, >>> >>> Am 03.07.2015 um 02:15 schrieb Simon Glass: >>>> >>>> When driver model is not used the current code does not correctly select >>>> the pinmux for the I2C bus. This bug was introduced by this commit: >>>> >>>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >>>> >>>> Signed-off-by: Simon Glass <sjg@chromium.org> >>>> --- >>>> >>>> drivers/i2c/s3c24x0_i2c.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> >>> Acked-by: Heiko Schocher <hs@denx.de> >>> >>> As it is a bugfix, this should go in the current release ... right? >> >> Minkyu, are you able to pick this up please? If not I can do it. >> > > Only this patch? or all of samsung related patches? Yes only this patch. It has been confirmed my Przemyslaw now too. Regards, Simon
Hi Simon, On 08/07/15 11:38, Simon Glass wrote: > Hi Minkyu, > > On 6 July 2015 at 19:36, Minkyu Kang <mk7.kang@samsung.com> wrote: >> Dear Simon, >> >> On 07/07/15 00:27, Simon Glass wrote: >>> Hi Minkyu, Przemyslaw, >>> >>> On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: >>>> Hello Simon, >>>> >>>> Am 03.07.2015 um 02:15 schrieb Simon Glass: >>>>> >>>>> When driver model is not used the current code does not correctly select >>>>> the pinmux for the I2C bus. This bug was introduced by this commit: >>>>> >>>>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >>>>> >>>>> Signed-off-by: Simon Glass <sjg@chromium.org> >>>>> --- >>>>> >>>>> drivers/i2c/s3c24x0_i2c.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> >>>> Acked-by: Heiko Schocher <hs@denx.de> >>>> >>>> As it is a bugfix, this should go in the current release ... right? >>> >>> Minkyu, are you able to pick this up please? If not I can do it. >>> >> >> Only this patch? or all of samsung related patches? > > Yes only this patch. It has been confirmed my Przemyslaw now too. > OK. then, do you want to take other patches to your tree? Thanks, Minkyu Kang.
Hi Minkyu, On 9 July 2015 at 19:43, Minkyu Kang <mk7.kang@samsung.com> wrote: > Hi Simon, > > On 08/07/15 11:38, Simon Glass wrote: >> Hi Minkyu, >> >> On 6 July 2015 at 19:36, Minkyu Kang <mk7.kang@samsung.com> wrote: >>> Dear Simon, >>> >>> On 07/07/15 00:27, Simon Glass wrote: >>>> Hi Minkyu, Przemyslaw, >>>> >>>> On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: >>>>> Hello Simon, >>>>> >>>>> Am 03.07.2015 um 02:15 schrieb Simon Glass: >>>>>> >>>>>> When driver model is not used the current code does not correctly select >>>>>> the pinmux for the I2C bus. This bug was introduced by this commit: >>>>>> >>>>>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >>>>>> >>>>>> Signed-off-by: Simon Glass <sjg@chromium.org> >>>>>> --- >>>>>> >>>>>> drivers/i2c/s3c24x0_i2c.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> >>>>> Acked-by: Heiko Schocher <hs@denx.de> >>>>> >>>>> As it is a bugfix, this should go in the current release ... right? >>>> >>>> Minkyu, are you able to pick this up please? If not I can do it. >>>> >>> >>> Only this patch? or all of samsung related patches? >> >> Yes only this patch. It has been confirmed my Przemyslaw now too. >> > > OK. > then, do you want to take other patches to your tree? There are still dependencies on u-boot-dm, so I cannot yet. But if you like I can do that later, after I have merged some more driver model support patches. Regards, Simon
Hello, On 07/10/2015 03:46 AM, Simon Glass wrote: > Hi Minkyu, > > On 9 July 2015 at 19:43, Minkyu Kang <mk7.kang@samsung.com> wrote: >> Hi Simon, >> >> On 08/07/15 11:38, Simon Glass wrote: >>> Hi Minkyu, >>> >>> On 6 July 2015 at 19:36, Minkyu Kang <mk7.kang@samsung.com> wrote: >>>> Dear Simon, >>>> >>>> On 07/07/15 00:27, Simon Glass wrote: >>>>> Hi Minkyu, Przemyslaw, >>>>> >>>>> On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: >>>>>> Hello Simon, >>>>>> >>>>>> Am 03.07.2015 um 02:15 schrieb Simon Glass: >>>>>>> >>>>>>> When driver model is not used the current code does not correctly select >>>>>>> the pinmux for the I2C bus. This bug was introduced by this commit: >>>>>>> >>>>>>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >>>>>>> >>>>>>> Signed-off-by: Simon Glass <sjg@chromium.org> >>>>>>> --- >>>>>>> >>>>>>> drivers/i2c/s3c24x0_i2c.c | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> >>>>>> Acked-by: Heiko Schocher <hs@denx.de> >>>>>> >>>>>> As it is a bugfix, this should go in the current release ... right? >>>>> >>>>> Minkyu, are you able to pick this up please? If not I can do it. >>>>> >>>> >>>> Only this patch? or all of samsung related patches? >>> >>> Yes only this patch. It has been confirmed my Przemyslaw now too. >>> >> >> OK. >> then, do you want to take other patches to your tree? > > There are still dependencies on u-boot-dm, so I cannot yet. But if you > like I can do that later, after I have merged some more driver model > support patches. > > Regards, > Simon > Simon, please wait a moment with merge the patchset. I will send a few comments today. Regards
On 10/07/15 10:46, Simon Glass wrote: > Hi Minkyu, > > On 9 July 2015 at 19:43, Minkyu Kang <mk7.kang@samsung.com> wrote: >> Hi Simon, >> >> On 08/07/15 11:38, Simon Glass wrote: >>> Hi Minkyu, >>> >>> On 6 July 2015 at 19:36, Minkyu Kang <mk7.kang@samsung.com> wrote: >>>> Dear Simon, >>>> >>>> On 07/07/15 00:27, Simon Glass wrote: >>>>> Hi Minkyu, Przemyslaw, >>>>> >>>>> On 5 July 2015 at 00:15, Heiko Schocher <hs@denx.de> wrote: >>>>>> Hello Simon, >>>>>> >>>>>> Am 03.07.2015 um 02:15 schrieb Simon Glass: >>>>>>> >>>>>>> When driver model is not used the current code does not correctly select >>>>>>> the pinmux for the I2C bus. This bug was introduced by this commit: >>>>>>> >>>>>>> 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api >>>>>>> >>>>>>> Signed-off-by: Simon Glass <sjg@chromium.org> >>>>>>> --- >>>>>>> >>>>>>> drivers/i2c/s3c24x0_i2c.c | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> >>>>>> Acked-by: Heiko Schocher <hs@denx.de> >>>>>> >>>>>> As it is a bugfix, this should go in the current release ... right? >>>>> >>>>> Minkyu, are you able to pick this up please? If not I can do it. >>>>> >>>> >>>> Only this patch? or all of samsung related patches? >>> >>> Yes only this patch. It has been confirmed my Przemyslaw now too. >>> >> >> OK. >> then, do you want to take other patches to your tree? > > There are still dependencies on u-boot-dm, so I cannot yet. But if you > like I can do that later, after I have merged some more driver model > support patches. > > Regards, > Simon > applied to u-boot-samsung. Thanks, Minkyu Kang
diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c index c053e84..9a04e48 100644 --- a/drivers/i2c/s3c24x0_i2c.c +++ b/drivers/i2c/s3c24x0_i2c.c @@ -1035,7 +1035,7 @@ static void process_nodes(const void *blob, int node_list[], int count, CONFIG_SYS_I2C_S3C24X0_SPEED); bus->node = node; bus->bus_num = i; - exynos_pinmux_config(PERIPH_ID_I2C0 + bus->id, flags); + exynos_pinmux_config(bus->id, flags); /* Mark position as used */ node_list[i] = -1;
When driver model is not used the current code does not correctly select the pinmux for the I2C bus. This bug was introduced by this commit: 8dfcbaa dm: i2c: s3c24x0: adjust to dm-i2c api Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/i2c/s3c24x0_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)