diff mbox

[U-Boot,26/55] dm: pmic: Correct the pmic_reg_write() implementation

Message ID 1435882592-487-27-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass July 3, 2015, 12:16 a.m. UTC 
This should write the register, not read it. Fix this bug.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/power/pmic/pmic-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Przemyslaw Marczak July 10, 2015, 11:53 a.m. UTC | #1 
Hello Simon,

On 07/03/2015 02:16 AM, Simon Glass wrote:
> This should write the register, not read it. Fix this bug.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   drivers/power/pmic/pmic-uclass.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/pmic/pmic-uclass.c b/drivers/power/pmic/pmic-uclass.c
> index d99cb9a..49709f3 100644
> --- a/drivers/power/pmic/pmic-uclass.c
> +++ b/drivers/power/pmic/pmic-uclass.c
> @@ -142,7 +142,7 @@ int pmic_reg_write(struct udevice *dev, uint reg, uint value)
>   	u8 byte = value;
>
>   	debug("%s: reg=%x, value=%x\n", __func__, reg, value);
> -	return pmic_read(dev, reg, &byte, 1);
> +	return pmic_write(dev, reg, &byte, 1);
>   }
>
>   int pmic_clrsetbits(struct udevice *dev, uint reg, uint clr, uint set)
>

Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Regards
Simon Glass July 27, 2015, 11:30 p.m. UTC | #2 
Applied to u-boot-dm.
diff mbox

Patch

diff --git a/drivers/power/pmic/pmic-uclass.c b/drivers/power/pmic/pmic-uclass.c
index d99cb9a..49709f3 100644
--- a/drivers/power/pmic/pmic-uclass.c
+++ b/drivers/power/pmic/pmic-uclass.c
@@ -142,7 +142,7 @@  int pmic_reg_write(struct udevice *dev, uint reg, uint value)
 	u8 byte = value;
 
 	debug("%s: reg=%x, value=%x\n", __func__, reg, value);
-	return pmic_read(dev, reg, &byte, 1);
+	return pmic_write(dev, reg, &byte, 1);
 }
 
 int pmic_clrsetbits(struct udevice *dev, uint reg, uint clr, uint set)