[v2] gpio/davinci: add interrupt support for GPIOs 16-31
diff mbox

Message ID 1435861890-23147-1-git-send-email-vitalya@ti.com
State New
Headers show

Commit Message

Vitaly Andrianov July 2, 2015, 6:31 p.m. UTC
Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
"binten" register (offset 8). Previous versions of GPIO only
used bit 0, which enables GPIO 0-15 interrupts.

Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
History

v2.
- use GENMASK to set binten. Thanks to Nori Sekhar's.

 drivers/gpio/gpio-davinci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sekhar Nori July 16, 2015, 9:04 a.m. UTC | #1
On Friday 03 July 2015 12:01 AM, Vitaly Andrianov wrote:
> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.
> 
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

Reviewed-by: Sekhar Nori <nsekhar@ti.com>

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij July 17, 2015, 12:16 p.m. UTC | #2
On Thu, Jul 2, 2015 at 8:31 PM, Vitaly Andrianov <vitalya@ti.com> wrote:

> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
> "binten" register (offset 8). Previous versions of GPIO only
> used bit 0, which enables GPIO 0-15 interrupts.
>
> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> History
>
> v2.
> - use GENMASK to set binten. Thanks to Nori Sekhar's.

This version applied for v4.3 with Sekhar's review tag.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vitaly Andrianov July 17, 2015, 2:51 p.m. UTC | #3
On 07/17/2015 08:16 AM, Linus Walleij wrote:
> On Thu, Jul 2, 2015 at 8:31 PM, Vitaly Andrianov <vitalya@ti.com> wrote:
>
>> Interrupts for GPIOs 16 through 31 are enabled by bit 1 in the
>> "binten" register (offset 8). Previous versions of GPIO only
>> used bit 0, which enables GPIO 0-15 interrupts.
>>
>> Signed-off-by: Vitaly Andrianov <vitalya@ti.com>
>> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> History
>>
>> v2.
>> - use GENMASK to set binten. Thanks to Nori Sekhar's.
>
> This version applied for v4.3 with Sekhar's review tag.
>
> Yours,
> Linus Walleij
>
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index c5e05c8..86cfe18 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -545,7 +545,7 @@  static int davinci_gpio_irq_setup(struct platform_device *pdev)
 		chips[0].chip.to_irq = gpio_to_irq_unbanked;
 		chips[0].gpio_irq = bank_irq;
 		chips[0].gpio_unbanked = pdata->gpio_unbanked;
-		binten = BIT(0);
+		binten = GENMASK(pdata->gpio_unbanked / 16, 0);
 
 		/* AINTC handles mask/unmask; GPIO handles triggering */
 		irq = bank_irq;